public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* compliation error with aio_abi.h
@ 2018-07-16 16:40 Laura Abbott
  2018-07-17 12:58 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Laura Abbott @ 2018-07-16 16:40 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Greg Kroah-Hartman, Darrick J. Wong, Linux Kernel Mailing List,
	linux-aio

Hi,

Fedora got a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1601529
with 4.18-rc4:

Steps to Reproduce:
1.echo 'int f;' | gcc -include linux/aio_abi.h -xc -c - -o /dev/null

Actual results:
/usr/include/asm/signal.h:127:2: error: unknown type name ‘size_t’
   size_t ss_size;
   ^~~~~~
In file included from <command-line>:32:
/usr/include/linux/aio_abi.h:115:2: error: unknown type name ‘size_t’
   size_t  sigsetsize;
   ^~~~~~

Expected results:
no errors, as in Fedora 28 kernel-headers-4.17.4-200.fc28.x86_64)


This looks like the structure that was introduced with 7a074e96dee6
("aio: implement io_pgetevents") . is #include <linux/signal.h>
the correct header? This breaks compilation of nginx
https://bugzilla.redhat.com/show_bug.cgi?id=1597674

Thanks,
Laura


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: compliation error with aio_abi.h
  2018-07-16 16:40 compliation error with aio_abi.h Laura Abbott
@ 2018-07-17 12:58 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2018-07-17 12:58 UTC (permalink / raw)
  To: Laura Abbott
  Cc: Christoph Hellwig, Greg Kroah-Hartman, Darrick J. Wong,
	Linux Kernel Mailing List, linux-aio

On Mon, Jul 16, 2018 at 09:40:19AM -0700, Laura Abbott wrote:
> This looks like the structure that was introduced with 7a074e96dee6
> ("aio: implement io_pgetevents") . is #include <linux/signal.h>
> the correct header? This breaks compilation of nginx
> https://bugzilla.redhat.com/show_bug.cgi?id=1597674

As far as the kernel is concerned it is the right header, but the
glibc side of signals is a mess.  I've thus submitted the fix below
to avoid exposing the signal bits at all:

https://marc.info/?l=linux-fsdevel&m=153131732618217&w=2

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-17 12:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-16 16:40 compliation error with aio_abi.h Laura Abbott
2018-07-17 12:58 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox