public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: m13297920107 <m13297920107@163.com>
Cc: "johan@kernel.org" <johan@kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"moviesong@aten-itlab.cn" <moviesong@aten-itlab.cn>,
	"billli@aten-itlab.cn" <billli@aten-itlab.cn>
Subject: Re: 来自m13297920107的邮件
Date: Tue, 17 Jul 2018 16:28:26 +0200	[thread overview]
Message-ID: <20180717142826.GA3464@localhost> (raw)
In-Reply-To: <9d354b9.f72d.164a87468d7.Coremail.m13297920107@163.com>

On Tue, Jul 17, 2018 at 09:35:58PM +0800, m13297920107 wrote:
> From dcd3f0aafbd3ac40c0bceb8e9d5941a29a1a5edd Mon Sep 17 00:00:00 2001
> From: Movie Song <MovieSong@aten-itlab.cn>
> Date: Tue, 17 Jul 2018 21:13:52 +0800
> Subject: [PATCH] This add a new device for ATEN
> Signed-off-by:MovieSong<MovieSong@aten-itlab.cn>

You're getting closer, but the patch is still whitespace damaged.

Again, try sending the patch to yourself first and make sure you can
apply it with git-am. You can also run checkpatch on the result to catch
some common mistakes.

Please also use a more descriptive commit summary (Subject) by using the
common prefix, for example:

	USB: serial: pl2303: add new device id for ATEN
	
and add a short commit message (which is currently empty).

The link I sent you earlier will show you an example of what the
end-result may look like.

Thanks,
Johan

           reply	other threads:[~2018-07-17 14:29 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <9d354b9.f72d.164a87468d7.Coremail.m13297920107@163.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180717142826.GA3464@localhost \
    --to=johan@kernel.org \
    --cc=billli@aten-itlab.cn \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m13297920107@163.com \
    --cc=moviesong@aten-itlab.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox