From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AEACECDFB1 for ; Tue, 17 Jul 2018 15:34:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 014DB20849 for ; Tue, 17 Jul 2018 15:34:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="HQtn2aGj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 014DB20849 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730093AbeGQQH2 (ORCPT ); Tue, 17 Jul 2018 12:07:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:50524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729663AbeGQQH2 (ORCPT ); Tue, 17 Jul 2018 12:07:28 -0400 Received: from localhost (unknown [122.178.206.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A7EF20839; Tue, 17 Jul 2018 15:34:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1531841656; bh=Odx7C7LLxB0hPvxPLqDMm97N8dkhL4WBzNNd1R8eATI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HQtn2aGjhZTWI145IFcdEmJftV4Ep5/pwmDl0lKvQsZUre3KiCf/dybS5ifHOBtoi 9aMlR8+svYmFIr7xm3POS3ODBmOOhnF74hWn9YNs3gCAhek1lkxtRZ0WFibq72QSZj zG4Y9AuWWJegWriPTK4fQV35bhX/fYKCtNvPNAzc= Date: Tue, 17 Jul 2018 21:04:07 +0530 From: Vinod To: Rob Herring Cc: Paul Cercueil , Mark Rutland , Ralf Baechle , Paul Burton , James Hogan , Zubair Lutfullah Kakakhel , Mathieu Malaterre , Daniel Silsby , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH 05/14] dmaengine: dma-jz4780: Add support for the JZ4740 SoC Message-ID: <20180717153407.GF3219@vkoul-mobl> References: <20180703123214.23090-1-paul@crapouillou.net> <20180703123214.23090-6-paul@crapouillou.net> <20180709171226.GK22377@vkoul-mobl> <20180716213339.GA19161@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180716213339.GA19161@rob-hp-laptop> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-07-18, 15:33, Rob Herring wrote: > On Mon, Jul 09, 2018 at 10:42:26PM +0530, Vinod wrote: > > On 03-07-18, 14:32, Paul Cercueil wrote: > > > > > enum jz_version { > > > + ID_JZ4740, > > > ID_JZ4770, > > > ID_JZ4780, > > > }; > > > @@ -247,6 +248,7 @@ static void jz4780_dma_desc_free(struct virt_dma_desc *vdesc) > > > } > > > > > > static const unsigned int jz4780_dma_ord_max[] = { > > > + [ID_JZ4740] = 5, > > > [ID_JZ4770] = 6, > > > [ID_JZ4780] = 7, > > > }; > > > @@ -801,11 +803,13 @@ static struct dma_chan *jz4780_of_dma_xlate(struct of_phandle_args *dma_spec, > > > } > > > > > > static const unsigned int jz4780_dma_nb_channels[] = { > > > + [ID_JZ4740] = 6, > > > [ID_JZ4770] = 6, > > > [ID_JZ4780] = 32, > > > }; > > > > I feel these should be done away with if we describe hardware in DT > > The compatible property can imply things like this. So what is the general recommendation, let DT describe hardware including version delta or use compatible to code that in driver? Is it documented anywhere? -- ~Vinod