From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 320C8ECDFB3 for ; Tue, 17 Jul 2018 19:37:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECB2020673 for ; Tue, 17 Jul 2018 19:37:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECB2020673 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730128AbeGQUL4 (ORCPT ); Tue, 17 Jul 2018 16:11:56 -0400 Received: from mail.bootlin.com ([62.4.15.54]:52842 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729704AbeGQULz (ORCPT ); Tue, 17 Jul 2018 16:11:55 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 7CD02208C4; Tue, 17 Jul 2018 21:37:48 +0200 (CEST) Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id 03D04207AB; Tue, 17 Jul 2018 21:37:37 +0200 (CEST) Date: Tue, 17 Jul 2018 21:37:36 +0200 From: Boris Brezillon To: Janusz Krzysztofik Cc: Miquel Raynal , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Krzysztof Kozlowski , Vladimir Zapolskiy , Gregory CLEMENT , Shreeya Patel , Arvind Yadav , linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH v3] mtd: rawnand: ams-delta: use GPIO lookup table Message-ID: <20180717213736.3cd0a747@bbrezillon> In-Reply-To: <20180709193850.20191-1-jmkrzyszt@gmail.com> References: <20180525222046.11200-1-jmkrzyszt@gmail.com> <20180709193850.20191-1-jmkrzyszt@gmail.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Janusz, On Mon, 9 Jul 2018 21:38:50 +0200 Janusz Krzysztofik wrote: > Now as Amstrad Delta board - the only user of this driver - provides > GPIO lookup tables, switch from GPIO numbers to GPIO descriptors and > use the table to locate required GPIO pins. > > Declare static variables for storing GPIO descriptors and replace > gpio_ function calls with their gpiod_ equivalents. > > Pin naming used by the driver should be followed while respective GPIO > lookup table is initialized by a board init code. > > Signed-off-by: Janusz Krzysztofik > --- > Changlog: > v1: Fix handling of devm_gpiod_get_optional() return values - thanks to > Andy Shevchenko. > v2: Remove problematic error code conversion, no longer needed if used > on top of commit d08605a64e67 ("ARM: OMAP1: ams-delta: move late > devices back to init_machine") already in linux-next and commit > 8853daf3b4ac ("gpiolib: Defer on non-DT find_chip_by_name() > failure") just applied to linux-gpio/devel. Sorry, but we can't apply this patch now because of the dependency on those 2 commits. I guess it's not a big issue if we defer it to 4.20. Alternatively, we could consider queuing it to mtd/fixes after 4.19-rc1 is out, but we'll need a good reason to do that (like a regression that this patch is supposed to fix). Note for your future contributions: for this kind of cross-subsystem changes, it's better to let everything go through a single tree (usually done by sending all patches in a single series and explaining the dependencies between the patches in the cover letter), but it's already too late here (I guess d08605a64e67 is in the omap tree and 8853daf3b4ac in the gpio one). Regards, Boris