* [PATCH] mtd: nand/raw: MTD_NAND_BCM47XXNFLASH needs CONFIG_BCMA
@ 2018-07-11 8:39 Arnd Bergmann
2018-07-11 8:44 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2018-07-11 8:39 UTC (permalink / raw)
To: Boris Brezillon, Miquel Raynal, David Woodhouse, Brian Norris,
Marek Vasut, Richard Weinberger
Cc: Arnd Bergmann, linux-mtd, linux-kernel
We already have a dependency on BCMA_NFLASH, which in turn depends on
BCMA, but since BCMA is a tristate option and BCMA_NFLASH is bool,
we can run into an invalid configuration with MTD_NAND_BCM47XXNFLASH=y
and BCMA=m:
drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.o: In function `bcm47xxnflash_ops_bcm4706_init':
ops_bcm4706.c:(.text+0x790): undefined reference to `bcma_chipco_pll_read'
Adding the dependency here forces MTD_NAND_BCM47XXNFLASH to only be
configured =m here so it can link against the BCMA driver.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mtd/nand/raw/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index 230311fa2cc0..b457f92d55d4 100644
--- a/drivers/mtd/nand/raw/Kconfig
+++ b/drivers/mtd/nand/raw/Kconfig
@@ -364,6 +364,7 @@ config MTD_NAND_BRCMNAND
config MTD_NAND_BCM47XXNFLASH
tristate "Support for NAND flash on BCM4706 BCMA bus"
depends on BCMA_NFLASH
+ depends on BCMA
help
BCMA bus can have various flash memories attached, they are
registered by bcma as platform devices. This enables driver for
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand/raw: MTD_NAND_BCM47XXNFLASH needs CONFIG_BCMA
2018-07-11 8:39 [PATCH] mtd: nand/raw: MTD_NAND_BCM47XXNFLASH needs CONFIG_BCMA Arnd Bergmann
@ 2018-07-11 8:44 ` Boris Brezillon
2018-07-18 7:50 ` Miquel Raynal
0 siblings, 1 reply; 3+ messages in thread
From: Boris Brezillon @ 2018-07-11 8:44 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Miquel Raynal, David Woodhouse, Brian Norris, Marek Vasut,
Richard Weinberger, linux-mtd, linux-kernel
On Wed, 11 Jul 2018 10:39:44 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> We already have a dependency on BCMA_NFLASH, which in turn depends on
> BCMA, but since BCMA is a tristate option and BCMA_NFLASH is bool,
> we can run into an invalid configuration with MTD_NAND_BCM47XXNFLASH=y
> and BCMA=m:
>
> drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.o: In function `bcm47xxnflash_ops_bcm4706_init':
> ops_bcm4706.c:(.text+0x790): undefined reference to `bcma_chipco_pll_read'
>
> Adding the dependency here forces MTD_NAND_BCM47XXNFLASH to only be
> configured =m here so it can link against the BCMA driver.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> drivers/mtd/nand/raw/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index 230311fa2cc0..b457f92d55d4 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -364,6 +364,7 @@ config MTD_NAND_BRCMNAND
> config MTD_NAND_BCM47XXNFLASH
> tristate "Support for NAND flash on BCM4706 BCMA bus"
> depends on BCMA_NFLASH
> + depends on BCMA
> help
> BCMA bus can have various flash memories attached, they are
> registered by bcma as platform devices. This enables driver for
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand/raw: MTD_NAND_BCM47XXNFLASH needs CONFIG_BCMA
2018-07-11 8:44 ` Boris Brezillon
@ 2018-07-18 7:50 ` Miquel Raynal
0 siblings, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2018-07-18 7:50 UTC (permalink / raw)
To: Boris Brezillon
Cc: Arnd Bergmann, David Woodhouse, Brian Norris, Marek Vasut,
Richard Weinberger, linux-mtd, linux-kernel
Hi Arnd,
Boris Brezillon <boris.brezillon@bootlin.com> wrote on Wed, 11 Jul 2018
10:44:46 +0200:
> On Wed, 11 Jul 2018 10:39:44 +0200
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > We already have a dependency on BCMA_NFLASH, which in turn depends on
> > BCMA, but since BCMA is a tristate option and BCMA_NFLASH is bool,
> > we can run into an invalid configuration with MTD_NAND_BCM47XXNFLASH=y
> > and BCMA=m:
> >
> > drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.o: In function `bcm47xxnflash_ops_bcm4706_init':
> > ops_bcm4706.c:(.text+0x790): undefined reference to `bcma_chipco_pll_read'
> >
> > Adding the dependency here forces MTD_NAND_BCM47XXNFLASH to only be
> > configured =m here so it can link against the BCMA driver.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
>
Applied with prefix changed to "mtd: rawnand:".
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-18 7:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-11 8:39 [PATCH] mtd: nand/raw: MTD_NAND_BCM47XXNFLASH needs CONFIG_BCMA Arnd Bergmann
2018-07-11 8:44 ` Boris Brezillon
2018-07-18 7:50 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).