From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3D82ECDFB8 for ; Wed, 18 Jul 2018 08:03:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6AFAF2075A for ; Wed, 18 Jul 2018 08:03:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AFAF2075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726982AbeGRIjv convert rfc822-to-8bit (ORCPT ); Wed, 18 Jul 2018 04:39:51 -0400 Received: from mail.bootlin.com ([62.4.15.54]:39837 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbeGRIjv (ORCPT ); Wed, 18 Jul 2018 04:39:51 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id D944A2074F; Wed, 18 Jul 2018 10:03:09 +0200 (CEST) Received: from xps13 (AAubervilliers-681-1-27-161.w90-88.abo.wanadoo.fr [90.88.147.161]) by mail.bootlin.com (Postfix) with ESMTPSA id 95E1E2072C; Wed, 18 Jul 2018 10:03:09 +0200 (CEST) Date: Wed, 18 Jul 2018 10:03:09 +0200 From: Miquel Raynal To: "Gustavo A. R. Silva" Cc: Wan ZongShun , Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: nuc900_nand: mark expected switch fall-through Message-ID: <20180718100309.49c5452a@xps13> In-Reply-To: <20180710132902.GA13541@embeddedor.com> References: <20180710132902.GA13541@embeddedor.com> Organization: Bootlin X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gustavo, Prefix should be "mtd: rawnand: nuc900:" "Gustavo A. R. Silva" wrote on Tue, 10 Jul 2018 08:29:02 -0500: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1471717 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva > --- > drivers/mtd/nand/raw/nuc900_nand.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/nuc900_nand.c b/drivers/mtd/nand/raw/nuc900_nand.c > index af5b32c9..53a9f6c 100644 > --- a/drivers/mtd/nand/raw/nuc900_nand.c > +++ b/drivers/mtd/nand/raw/nuc900_nand.c > @@ -191,8 +191,9 @@ static void nuc900_nand_command_lp(struct mtd_info *mtd, unsigned int command, > return; > > case NAND_CMD_READ0: > - > write_cmd_reg(nand, NAND_CMD_READSTART); > + /* fall through */ Have you checked this is actually the right thing to do? Thanks, Miquèl