From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA178ECDFBB for ; Wed, 18 Jul 2018 13:26:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 635402075A for ; Wed, 18 Jul 2018 13:26:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 635402075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731087AbeGRODx (ORCPT ); Wed, 18 Jul 2018 10:03:53 -0400 Received: from mail.us.es ([193.147.175.20]:58872 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730795AbeGRODw (ORCPT ); Wed, 18 Jul 2018 10:03:52 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 0B725C3496 for ; Wed, 18 Jul 2018 15:24:01 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id ECD71DA57F for ; Wed, 18 Jul 2018 15:24:00 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id E25E8DA573; Wed, 18 Jul 2018 15:24:00 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 01670DA73F; Wed, 18 Jul 2018 15:23:59 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 18 Jul 2018 15:23:59 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id D115A4265A4E; Wed, 18 Jul 2018 15:23:58 +0200 (CEST) Date: Wed, 18 Jul 2018 15:25:52 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Matthew Wilcox Cc: Stephen Rothwell , NetFilter , Linux-Next Mailing List , Linux Kernel Mailing List , Varsha Rao Subject: Re: linux-next: build failure after merge of the ida tree Message-ID: <20180718132552.oxy5gmwwyysoa7xr@salvia> References: <20180718165406.6f262266@canb.auug.org.au> <20180718092426.mxdti3jes5jsssta@salvia> <20180718115919.GB4949@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180718115919.GB4949@bombadil.infradead.org> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 18, 2018 at 04:59:19AM -0700, Matthew Wilcox wrote: > On Wed, Jul 18, 2018 at 11:24:26AM +0200, Pablo Neira Ayuso wrote: > > I see, we have no more lockless API for IDA anymore :-(. In our case, > > we were already protected by the the nfnl_lock mutex, which it was > > sufficient to ensure non-concurrent access to IDA structures. > > You're actually the first user for whom this is true. For every other > user, the requirement to manage their own spinlock was a pain. > > > Unless I'm missing anything, the new API forces use to the spinlock > > call with disabled irq for each time we update something from the > > netfilter netlink interface, so that's a no-go for us. > > I can't believe that's a serious problem for you, though. You're calling > sscanf(), this can't possibly be a performance path. It's not about performance, this is control plane code. This is disabling irqs, which is something we don't need.