From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F8F8ECDFB8 for ; Wed, 18 Jul 2018 16:31:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3AA520673 for ; Wed, 18 Jul 2018 16:31:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="VEaNS9Iy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3AA520673 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731455AbeGRRKQ (ORCPT ); Wed, 18 Jul 2018 13:10:16 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38762 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731105AbeGRRKQ (ORCPT ); Wed, 18 Jul 2018 13:10:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=bOaW+1L54nAup1fq2weOn/AzHRwlKkaprONg6QX7mkw=; b=VEaNS9Iy8GIQKvmQFH/TJeISXBsXBwMcaSxN7eZ9z7Bq/e7gIYDyXzECF8WjTWOUrhD9Psy8re/u9vykYQlpQ3NPqFSkVUTfGvOj2lgoon8ltwERuaGq7Veewi00sTn/YKBnUy4XPvnJ9WPNE/R2tLqpgdNrHxnev1ei4IwU1Uo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1ffpM5-00043D-M4; Wed, 18 Jul 2018 18:31:09 +0200 Date: Wed, 18 Jul 2018 18:31:09 +0200 From: Andrew Lunn To: Bartosz Golaszewski Cc: Sekhar Nori , Kevin Hilman , Russell King , Grygorii Strashko , "David S . Miller" , Srinivas Kandagatla , Lukas Wunner , Rob Herring , Florian Fainelli , Dan Carpenter , Ivan Khoronzhuk , David Lechner , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, netdev@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 2/5] net: add an info message to eth_platform_get_mac_address() Message-ID: <20180718163109.GB12477@lunn.ch> References: <20180718161035.7005-1-brgl@bgdev.pl> <20180718161035.7005-3-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180718161035.7005-3-brgl@bgdev.pl> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 18, 2018 at 06:10:32PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Many drivers that read the MAC address from EEPROM or MTD emit a log > message when they succeed. Since this function is meant to be reused > in those drivers instead of reimplementing the same operation > everywhere, add an info message when we successfully read the MAC > address. Hi Bartosz This makes eth_platform_get_mac_address() generally more verbose, which i guess people won't like. To keep it backwards compatible, it would be better to issue the message just when EEPROM to MTD is used. Andrew