From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "vinholikatti@gmail.com" <vinholikatti@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"sayalil@codeaurora.org" <sayalil@codeaurora.org>,
"riteshh@codeaurora.org" <riteshh@codeaurora.org>,
"evgreen@chromium.org" <evgreen@chromium.org>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"subhashj@codeaurora.org" <subhashj@codeaurora.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"vivek.gautam@codeaurora.org" <vivek.gautam@codeaurora.org>,
"rnayak@codeaurora.org" <rnayak@codeaurora.org>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>
Subject: Re: [PATCH V5 2/2] scsi: ufs: Add configfs support for ufs provisioning
Date: Wed, 18 Jul 2018 19:45:31 +0200 [thread overview]
Message-ID: <20180718174531.GA2008@kroah.com> (raw)
In-Reply-To: <16c8acaec092ef989ec20d0b006a434bc0de250c.camel@wdc.com>
On Wed, Jul 18, 2018 at 05:30:07PM +0000, Bart Van Assche wrote:
> On Wed, 2018-07-18 at 10:56 +0200, gregkh@linuxfoundation.org wrote:
> > On Tue, Jul 17, 2018 at 09:06:35PM +0000, Bart Van Assche wrote:
> > > On Tue, 2018-07-17 at 13:23 -0700, Evan Green wrote:
> > > > I'm not dead set on binary, since as above I could do it either way,
> > > > but it seemed worth at least talking through. Let me know what you
> > > > think.
> > >
> > > The configfs documentation (Documentation/filesystems/configfs/configfs.txt)
> > > is clear about this: "Preferably only one value per file should be used." So
> > > I would like to hear the opinion of someone who has more authority than I
> > > with regard to configfs.
> >
> > Don't we have "binary" files for configfs? We have them for sysfs, they
> > are for files that are not touched by the kernel and just "pass-through"
> > to the hardware. Would that work here as well?
>
> If a new version of the UFS spec would be introduced and that new version of the
> spec introduces a new layout for the binary descriptor, will it be possible for
> user space software to figure out which version of the binary descriptor format
> that has to be used?
If a new UFS spec was crazy enough to keep the same field name but
change the layout of the field, well, the UFS spec authors deserve all
of the pain and suffering that would cause to be heaped on them.
Seriously, it's not hard to do this right, go fix the spec before they
do something stupid.
And you are reporting the version of the UFS spec that your device
supports to userspace, right? So is this really a problem even if the
spec authors are that foolish?
thanks,
greg k-h
next prev parent reply other threads:[~2018-07-18 17:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1530858040-13971-1-git-send-email-sayalil@codeaurora.org>
2018-07-06 6:20 ` [PATCH V5 1/2] scsi: ufs: set the device reference clock setting Sayali Lokhande
2018-07-06 21:07 ` Rob Herring
2018-07-16 8:28 ` Sayali Lokhande
2018-07-06 6:20 ` [PATCH V5 2/2] scsi: ufs: Add configfs support for ufs provisioning Sayali Lokhande
2018-07-08 20:21 ` Christoph Hellwig
2018-07-11 9:50 ` Sayali Lokhande
2018-07-17 12:48 ` Christoph Hellwig
2018-07-09 17:48 ` Evan Green
2018-07-16 8:10 ` Sayali Lokhande
2018-07-16 23:46 ` Evan Green
2018-07-17 0:04 ` Bart Van Assche
2018-07-17 20:23 ` Evan Green
2018-07-17 21:06 ` Bart Van Assche
2018-07-18 8:56 ` gregkh
2018-07-18 17:30 ` Bart Van Assche
2018-07-18 17:45 ` gregkh [this message]
2018-07-30 7:46 ` Sayali Lokhande
2018-07-30 23:39 ` Evan Green
2018-07-31 5:18 ` Sayali Lokhande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718174531.GA2008@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Bart.VanAssche@wdc.com \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=evgreen@chromium.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=riteshh@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=sayalil@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox