Re: [PATCH V5 2/2] scsi: ufs: Add configfs support for ufs provisioning

Bart Van Assche
2018-07-17T00:04:42Z

On Mon, 2018-07-16 at 16:46 -0700, Evan Green wrote:
> I see Bart has chimed in on the next series with a suggestion to break
> out each field into individual files within configfs. Bart, what are
> your feelings about converting to a binary attribute? I remember when
> I did my sysfs equivalent of this patch, somebody chimed in indicating
> a "commit" file might be needed so that the new configuration could be
> written in one fell swoop. One advantage of the binary attribute is
> that it writes the configuration atomically.

Hello Evan,

I may be missing some UFS background information. But since a configfs interface
is being added I think the same rule applies as to all Linux kernel user space
interfaces, namely that it should be backwards compatible. Additionally, if
anyone ever will want to use this interface from a shell script, I think that
it will be much easier to write multiple ASCII attributes than a single binary
attribute.

Bart.