From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB5D7ECDFBB for ; Wed, 18 Jul 2018 23:07:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC4BB20850 for ; Wed, 18 Jul 2018 23:07:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC4BB20850 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730456AbeGRXrX (ORCPT ); Wed, 18 Jul 2018 19:47:23 -0400 Received: from mga09.intel.com ([134.134.136.24]:10306 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727254AbeGRXrX (ORCPT ); Wed, 18 Jul 2018 19:47:23 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2018 16:07:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,371,1526367600"; d="scan'208";a="68038629" Received: from rdvivi-vienna.jf.intel.com (HELO intel.com) ([10.7.196.88]) by orsmga003.jf.intel.com with ESMTP; 18 Jul 2018 16:07:06 -0700 Date: Wed, 18 Jul 2018 16:07:05 -0700 From: Rodrigo Vivi To: Lyude Paul Cc: dri-devel@lists.freedesktop.org, David Airlie , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/print: Fix DRM_DEBUG_DP macro Message-ID: <20180718230705.GD2146@intel.com> References: <20180718215716.5784-1-lyude@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180718215716.5784-1-lyude@redhat.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 18, 2018 at 05:57:16PM -0400, Lyude Paul wrote: > This isn't supposed to take dev as an argument, I guess no one noticed! Apparently no one using it... Why don't we just kill it? > > Signed-off-by: Lyude Paul anyways, if you prefer to keep or have plans to use: Reviewed-by: Rodrigo Vivi > --- > include/drm/drm_print.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h > index 767c90b654c5..fc08584a5101 100644 > --- a/include/drm/drm_print.h > +++ b/include/drm/drm_print.h > @@ -310,7 +310,7 @@ void drm_err(const char *format, ...); > > #define DRM_DEV_DEBUG_DP(dev, fmt, ...) \ > drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__) > -#define DRM_DEBUG_DP(dev, fmt, ...) \ > +#define DRM_DEBUG_DP(fmt, ...) \ > drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__) > > #define _DRM_DEV_DEFINE_DEBUG_RATELIMITED(dev, category, fmt, ...) \ > -- > 2.17.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel