From: Shawn Guo <shawnguo@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: s.hauer@pengutronix.de, kernel@pengutronix.de,
fabio.estevam@nxp.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Linux-imx@nxp.com
Subject: Re: [PATCH V2] soc: imx: gpc: restrict register range for regmap access
Date: Thu, 19 Jul 2018 10:24:26 +0800 [thread overview]
Message-ID: <20180719022424.GO4576@dragon> (raw)
In-Reply-To: <1531798126-24360-1-git-send-email-Anson.Huang@nxp.com>
On Tue, Jul 17, 2018 at 11:28:46AM +0800, Anson Huang wrote:
> GPC registers are NOT continuous, some registers are
> reserved and accessing them from userspace will trigger
> external abort, add regmap register access table to
> avoid below abort:
>
> root@imx6slevk:~# cat /sys/kernel/debug/regmap/20dc000.gpc/registers
> [ 108.480477] Unhandled fault: imprecise external abort (0x1406) at 0xb6db5004
> [ 108.487985] pgd = 42b54bfd
> [ 108.490741] [b6db5004] *pgd=ba1b7831
> [ 108.494386] Internal error: : 1406 [#1] SMP ARM
> [ 108.498943] Modules linked in:
> [ 108.502043] CPU: 0 PID: 389 Comm: cat Not tainted 4.18.0-rc1-00074-gc9f1f60-dirty #482
> [ 108.509982] Hardware name: Freescale i.MX6 SoloLite (Device Tree)
> [ 108.516123] PC is at regmap_mmio_read32le+0x20/0x24
> [ 108.521031] LR is at regmap_mmio_read+0x40/0x60
> [ 108.525586] pc : [<c059cf74>] lr : [<c059d1ac>] psr: 20060093
> [ 108.531875] sp : eccf1d98 ip : eccf1da8 fp : eccf1da4
> [ 108.537122] r10: ec2d3800 r9 : eccf1f60 r8 : ecfc0000
> [ 108.542370] r7 : eccf1e2c r6 : eccf1e2c r5 : 00000028 r4 : ec338e00
> [ 108.548920] r3 : 00000000 r2 : eccf1e2c r1 : f0980028 r0 : 00000000
> [ 108.555474] Flags: nzCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment none
> [ 108.562720] Control: 10c5387d Table: acf4004a DAC: 00000051
> [ 108.568491] Process cat (pid: 389, stack limit = 0xd4318a65)
> [ 108.574174] Stack: (0xeccf1d98 to 0xeccf2000)
>
> Fixes: 721cabf6c660 ("soc: imx: move PGC handling to a new GPC driver")
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied, thanks.
prev parent reply other threads:[~2018-07-19 2:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 3:28 [PATCH V2] soc: imx: gpc: restrict register range for regmap access Anson Huang
2018-07-19 2:24 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719022424.GO4576@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).