From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URG_BIZ,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D97BECDFB8 for ; Thu, 19 Jul 2018 03:12:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C92062084C for ; Thu, 19 Jul 2018 03:12:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C92062084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730770AbeGSDwy (ORCPT ); Wed, 18 Jul 2018 23:52:54 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:59452 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729914AbeGSDwy (ORCPT ); Wed, 18 Jul 2018 23:52:54 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6J39NFD050615 for ; Wed, 18 Jul 2018 23:11:59 -0400 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0a-001b2d01.pphosted.com with ESMTP id 2kab29q7t6-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 18 Jul 2018 23:11:59 -0400 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 18 Jul 2018 23:11:58 -0400 Received: from b01cxnp22034.gho.pok.ibm.com (9.57.198.24) by e17.ny.us.ibm.com (146.89.104.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 18 Jul 2018 23:11:54 -0400 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6J3BrFd65142972 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 19 Jul 2018 03:11:53 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3F558B2064; Wed, 18 Jul 2018 23:11:43 -0400 (EDT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1F1C3B205F; Wed, 18 Jul 2018 23:11:43 -0400 (EDT) Received: from paulmck-ThinkPad-W541 (unknown [9.80.233.56]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 18 Jul 2018 23:11:43 -0400 (EDT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id C217816CA21C; Wed, 18 Jul 2018 20:11:52 -0700 (PDT) Date: Wed, 18 Jul 2018 20:11:52 -0700 From: "Paul E. McKenney" To: Frederic Weisbecker Cc: David Woodhouse , Peter Zijlstra , mhillenb@amazon.de, linux-kernel , kvm Subject: Re: [RFC] Make need_resched() return true when rcu_urgent_qs requested Reply-To: paulmck@linux.vnet.ibm.com References: <1531168538.26547.5.camel@infradead.org> <20180709204248.GF3593@linux.vnet.ibm.com> <1531169145.26547.8.camel@infradead.org> <20180709210532.GH3593@linux.vnet.ibm.com> <20180709220823.GA18045@linux.vnet.ibm.com> <1531319025.8759.57.camel@infradead.org> <20180711144303.GQ3593@linux.vnet.ibm.com> <20180711164952.GA29994@linux.vnet.ibm.com> <20180719003205.GB5595@lerouge> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180719003205.GB5595@lerouge> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 18071903-0040-0000-0000-00000451051F X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009389; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01062857; UDB=6.00545745; IPR=6.00840710; MB=3.00022196; MTD=3.00000008; XFM=3.00000015; UTC=2018-07-19 03:11:56 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18071903-0041-0000-0000-00000857316E Message-Id: <20180719031152.GR12945@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-19_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807190031 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 19, 2018 at 02:32:06AM +0200, Frederic Weisbecker wrote: > On Wed, Jul 11, 2018 at 06:03:42PM +0100, David Woodhouse wrote: > > On Wed, 2018-07-11 at 09:49 -0700, Paul E. McKenney wrote: > > > And here is an updated v4.15 patch with Marius's Reported-by and David's > > > fix to my lost exclamation point. > > > > Thanks. Are you sending the original version of that to Linus? It'd be > > useful to have the commit ID so that we can watch for it landing, and > > chase this one up to Greg. > > > > As discussed on IRC, this patch reduces synchronize_sched() latency for > > us from ~4600s to ~160ms, which is nice. > > > > However, it isn't going to be sufficient in the NO_HZ_FULL case. For > > that you want a patch like the one below, which happily reduces the > > latency in our (!NO_HZ_FULL) case still further to ~40ms. > > That is interesting. As I replied to Paul, we are already calling > rcu_user_enter/exit() on guest_enter/exit_irqsoff(). So I'm wondering why > you're seeing such an optimization by repeating those calls. > > Perhaps the rcu_user_* somehow aren't actually called from > __context_tracking_enter()...? Some bug in context tracking? > Otherwise it's a curious side effect. David is working with v4.15. Is this maybe something that has changed since then? Thanx, Paul