From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EB50ECDFBB for ; Thu, 19 Jul 2018 03:20:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B597220862 for ; Thu, 19 Jul 2018 03:20:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ocvS+45E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B597220862 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726462AbeGSEBN (ORCPT ); Thu, 19 Jul 2018 00:01:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:45056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725739AbeGSEBN (ORCPT ); Thu, 19 Jul 2018 00:01:13 -0400 Received: from dragon (unknown [45.56.152.101]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39614206B7; Thu, 19 Jul 2018 03:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1531970417; bh=4wyoPHsXd4hhJA1GIbaPFHA+mbhDs/aMJxCxUXAHTus=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ocvS+45EoFPgJ681lZHnzMCriWCbcEIAFY5xtRtJHvRaPzt5ky+PBPpwHoiA37XND FS2eEvGOC3btOdyn9VY7GiFIZGuLFLunmiTNzC0VFMbogQA5EHunEJhpm3WWNMpc1y V/pvuK/2udlxENU60Z6wpFsjk150OMDezmvYfAac= Date: Thu, 19 Jul 2018 11:20:03 +0800 From: Shawn Guo To: Anson Huang , Viresh Kumar Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, fabio.estevam@nxp.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0 Message-ID: <20180719032002.GT4576@dragon> References: <1531896889-21377-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1531896889-21377-1-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 18, 2018 at 02:54:49PM +0800, Anson Huang wrote: > Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs") > added "operating-points" property for all CPUs, but missed i.MX7D's cpu0, > this patch adds it. > > Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs") > Signed-off-by: Anson Huang In general, when you send a patch fixing a commit, you should have the author of that commit copied. I added Viresh here. It looks like a wrong fix to me. It seems that commit b97872d4eb22 shouldn't change imx7d.dtsi at all. So the correct fix would be reverting the change on imx7d.dtsi, @Viresh? Shawn > --- > arch/arm/boot/dts/imx7d.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi > index 9a772fc..30a1a73 100644 > --- a/arch/arm/boot/dts/imx7d.dtsi > +++ b/arch/arm/boot/dts/imx7d.dtsi > @@ -9,6 +9,11 @@ > / { > cpus { > cpu0: cpu@0 { > + operating-points = < > + /* KHz uV */ > + 996000 1075000 > + 792000 975000 > + >; > clock-frequency = <996000000>; > operating-points-v2 = <&cpu0_opp_table>; > #cooling-cells = <2>; > -- > 2.7.4 >