From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: Adam Borowski <kilobyte@angband.pl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-console@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] vt: no blinking on console, 256/24-bit color improvements
Date: Thu, 19 Jul 2018 11:47:49 +0100 [thread overview]
Message-ID: <20180719114749.00a7f979@alans-desktop> (raw)
In-Reply-To: <20180718030152.kdq53mwpdfusvwl5@angband.pl>
On Wed, 18 Jul 2018 05:01:52 +0200
Adam Borowski <kilobyte@angband.pl> wrote:
> Hi!
> Here's a patchset with two entangled improvements:
>
> * it'd be good to get rid of blinking where possible. Even CGA (thus VGA)
> allows disabling it, rendering such characters with a bright background
> instead.
That's a matter of taste so needs to configurable. Changing the default
ought I think to be its own patch as it's a separate discussion to having
the choice there and easy to make.
For the palette why does it needs changing and exactly what standards
document defines 'right', especially given we don't do ICC in console
mode ? Have you tested the values used against multiple monitor types and
cards with a light meter ?
BTW visibly breaking the Nvidia crud is also fine. They'll then actually
bother to fix it and uually quite soon.
Alan
next prev parent reply other threads:[~2018-07-19 10:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 3:01 [PATCH 0/6] vt: no blinking on console, 256/24-bit color improvements Adam Borowski
2018-07-18 3:03 ` [PATCH 1/6] vt: drop unused struct vt_struct Adam Borowski
2018-07-18 3:03 ` [PATCH 2/6] vt: add console flag "unblinking" Adam Borowski
2018-07-18 3:03 ` [PATCH 3/6] vt: let \e[100m use bright background if unblinking Adam Borowski
2018-07-18 3:03 ` [PATCH 4/6] vt: change 256-color palette to match all(?) modern terminals Adam Borowski
2018-07-18 3:03 ` [PATCH 5/6] vt: compensate for brightening the 256-color palette Adam Borowski
2018-07-18 3:03 ` [PATCH 6/6] vt: support bright backgrounds for \e[48m if unblinking Adam Borowski
2018-07-19 10:47 ` Alan Cox [this message]
2018-07-19 14:28 ` [PATCH 0/6] vt: no blinking on console, 256/24-bit color improvements Adam Borowski
2018-07-19 14:34 ` Geert Uytterhoeven
2018-07-21 7:43 ` Greg Kroah-Hartman
2018-07-21 21:38 ` Adam Borowski
2018-07-23 8:53 ` Geert Uytterhoeven
2018-07-23 10:41 ` Adam Borowski
2018-07-23 11:07 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719114749.00a7f979@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=b.zolnierkie@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kilobyte@angband.pl \
--cc=linux-console@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox