From: Christoph Hellwig <hch@lst.de>
To: Geoff Levand <geoff@infradead.org>
Cc: Fredrik Noring <noring@nocrew.org>,
Christoph Hellwig <hch@lst.de>,
Robin Murphy <robin.murphy@arm.com>,
m.szyprowski@samsung.com, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, JuergenUrban@gmx.de
Subject: Re: [PATCH] dma-mapping: Relax warnings for per-device areas
Date: Thu, 19 Jul 2018 15:16:19 +0200 [thread overview]
Message-ID: <20180719131619.GA13129@lst.de> (raw)
In-Reply-To: <ac14e13b-82fb-c623-6dcb-4c944120eb24@infradead.org>
On Wed, Jul 18, 2018 at 02:55:59PM -0700, Geoff Levand wrote:
> Hi,
>
> On 07/17/2018 09:33 AM, Fredrik Noring wrote:
> >>> Here are three other regressions related to the coherent mask WARN_ON_ONCE:
> >>
> >> They are a pretty strong indication that yes, you should really set
> >> the coherent mask if you ever do coherent allocations..
> >
> > I'm unfortunately unfamiliar with the USB drivers for the PS3. Geoff, what
> > do you think about setting a coherent mask?
>
> I guess we need to add a dma_set_coherent_mask() call in the driver
> probe routines. I'll send out a patch.
Yes, exactly!
prev parent reply other threads:[~2018-07-19 13:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 13:08 [PATCH] dma-mapping: Relax warnings for per-device areas Robin Murphy
2018-07-03 16:47 ` Fredrik Noring
2018-07-05 19:36 ` Christoph Hellwig
2018-07-06 11:57 ` Robin Murphy
2018-07-06 14:19 ` Fredrik Noring
2018-07-06 16:46 ` Robin Murphy
2018-07-06 20:54 ` Fredrik Noring
2018-07-06 23:35 ` Aw: " "Jürgen Urban"
2018-07-07 6:32 ` Fredrik Noring
2018-07-08 20:47 ` Aw: " "Jürgen Urban"
2018-07-15 12:28 ` Fredrik Noring
2018-07-17 14:57 ` Christoph Hellwig
2018-07-17 16:33 ` Fredrik Noring
2018-07-18 21:55 ` Geoff Levand
2018-07-19 13:16 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719131619.GA13129@lst.de \
--to=hch@lst.de \
--cc=JuergenUrban@gmx.de \
--cc=geoff@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=noring@nocrew.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox