* [PATCH] x86: Use PTR_ERR_OR_ZERO
@ 2018-07-19 13:22 YueHaibing
2018-07-19 14:37 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-07-19 13:22 UTC (permalink / raw)
To: tglx, mingo, hpa
Cc: linux-kernel, x86, kstewart, gregkh, pombredanne, YueHaibing
Replace IS_ERR/PTR_ERR
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
arch/x86/kernel/pcspeaker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/pcspeaker.c b/arch/x86/kernel/pcspeaker.c
index da5190a..4a710ff 100644
--- a/arch/x86/kernel/pcspeaker.c
+++ b/arch/x86/kernel/pcspeaker.c
@@ -9,6 +9,6 @@ static __init int add_pcspkr(void)
pd = platform_device_register_simple("pcspkr", -1, NULL, 0);
- return IS_ERR(pd) ? PTR_ERR(pd) : 0;
+ return PTR_ERR_OR_ZERO(pd);
}
device_initcall(add_pcspkr);
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: Use PTR_ERR_OR_ZERO
2018-07-19 13:22 [PATCH] x86: Use PTR_ERR_OR_ZERO YueHaibing
@ 2018-07-19 14:37 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-07-19 14:37 UTC (permalink / raw)
To: YueHaibing; +Cc: tglx, mingo, hpa, linux-kernel, x86, kstewart, pombredanne
On Thu, Jul 19, 2018 at 09:22:53PM +0800, YueHaibing wrote:
> Replace IS_ERR/PTR_ERR
That says what you did, not why.
Please fix and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-19 14:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-19 13:22 [PATCH] x86: Use PTR_ERR_OR_ZERO YueHaibing
2018-07-19 14:37 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox