From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AC01ECDFBB for ; Fri, 20 Jul 2018 12:48:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAC21206B7 for ; Fri, 20 Jul 2018 12:48:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="uv26kIVL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAC21206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390515AbeGTNgl (ORCPT ); Fri, 20 Jul 2018 09:36:41 -0400 Received: from merlin.infradead.org ([205.233.59.134]:59498 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390387AbeGTNgk (ORCPT ); Fri, 20 Jul 2018 09:36:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vuHDbp4HrcFSeP0prUcVNQaMissxlJ2lZl5x1ex/8g0=; b=uv26kIVLxvHpGO2MFs60VJWr0 61NJAqM0IxPHswOUlMOQikT4N4C3PRG1Ehv0NGxXasODpL34MAAILaKEzEmVKDx2kJlktxuyShP8A UMmxgTn/tv5twCTKqvTWO1xcN38mnUb3WJ9V6y74VOO4629yFyw0/t/7NR/ritLh7pBWSkFe0lXdr t8+lDxOODvw2AiqiKQZt8zWIzw19NoTdDQwwRU1nWs5lt09PwR3jznpPZXfz18xEhyZrRFDQLhdPZ d4VCaGh6nnqIAArTsw1Dxz5ZEwVrTuBuPUlSNIRqBRjeqX2IaUahDVWuzdwWstnFdNmCLQEW/xYu+ 7OlcsqHlg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fgUpc-0003Nw-4v; Fri, 20 Jul 2018 12:48:24 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id D092520275F36; Fri, 20 Jul 2018 14:48:21 +0200 (CEST) Date: Fri, 20 Jul 2018 14:48:21 +0200 From: Peter Zijlstra To: Daniel Bristot de Oliveira Cc: linux-kernel@vger.kernel.org, Clark Williams , Juri Lelli , Luca Abeni , Tommaso Cucinotta , Steven Rostedt , Ingo Molnar , stable@vger.kernel.org Subject: Re: [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task Message-ID: <20180720124821.GB2512@hirez.programming.kicks-ass.net> References: <20180720124615.GM2476@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180720124615.GM2476@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 20, 2018 at 02:46:15PM +0200, Peter Zijlstra wrote: > On Fri, Jul 20, 2018 at 11:16:30AM +0200, Daniel Bristot de Oliveira wrote: > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > > index fbfc3f1d368a..8b50eea4b607 100644 > > --- a/kernel/sched/deadline.c > > +++ b/kernel/sched/deadline.c > > @@ -2090,8 +2090,14 @@ static int push_dl_task(struct rq *rq) > > sub_rq_bw(&next_task->dl, &rq->dl); > > set_task_cpu(next_task, later_rq->cpu); > > add_rq_bw(&next_task->dl, &later_rq->dl); > > + > > + /* > > + * Update the later_rq clock here, because the clock is used > > + * by the cpufreq_update_util() inside __add_running_bw(). > > + */ > > + update_rq_clock(later_rq); > > add_running_bw(&next_task->dl, &later_rq->dl); > > - activate_task(later_rq, next_task, 0); > > + activate_task(later_rq, next_task, ENQUEUE_NOCLOCK); > > ret = 1; > > > > resched_curr(later_rq); > > Why isn't push_rt_task() affected by the very same issue? Aah, I see, its the add_running_bw() think; for which RT doesn't have a counter-part.