Re: [PATCH 2/3] dt-bindings: arm: syna: add support for the AS370 SoC

Rob Herring
2018-07-20T15:15:33Z

On Fri, Jul 13, 2018 at 05:24:57PM +0800, Jisheng Zhang wrote:
> The AS370 SoC is a new derivative of the berlin family. The only
> difference is the SoC isn't named as berlin*.

So is it a derivative or just rebranded?

> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> ---
> Documentation/devicetree/bindings/arm/syna.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/syna.txt b/Documentation/devicetree/bindings/arm/syna.txt
> index 3bab18409b7a..3ba1d7b5ee74 100644
> --- a/Documentation/devicetree/bindings/arm/syna.txt
> +++ b/Documentation/devicetree/bindings/arm/syna.txt
> @@ -1,4 +1,4 @@
> -Marvell Berlin SoC Family Device Tree Bindings
> +Synaptics SoC Device Tree Bindings

Perhaps some note about what has happened here. Otherwise it looks
strange having "Marvell Berlin" in the document when the title says
Synaptics SoC.

> ---------------------------------------------------------------
>
> Work in progress statement:
> @@ -13,6 +13,10 @@ stable binding/ABI.
>
> ---------------------------------------------------------------
>
> +Boards with the Synaptics AS370 SoC shall have the following properties:
> + Required root node property:
> + compatible: "syna,as370"
> +
> Boards with a SoC of the Marvell Berlin family, e.g. Armada 1500
> shall have the following properties:
>
> --
> 2.18.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html