linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	pombredanne@nexb.com, kstewart@linuxfoundation.org,
	tglx@linutronix.de, John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 03/14] staging:rtl8192u: Rename structure member FirstChnl - Style
Date: Fri, 20 Jul 2018 21:21:31 +0100	[thread overview]
Message-ID: <20180720202142.26312-4-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180720202142.26312-1-johnfwhitmore@gmail.com>

Rename structure member FirstChnl to first_channel. This coding style change
clears a checkpatch issue with CamelCase naming. This change should not impact
the runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/dot11d.c | 10 +++++-----
 drivers/staging/rtl8192u/ieee80211/dot11d.h |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.c b/drivers/staging/rtl8192u/ieee80211/dot11d.c
index 8ac08ee5256e..f24dae97bc0d 100644
--- a/drivers/staging/rtl8192u/ieee80211/dot11d.c
+++ b/drivers/staging/rtl8192u/ieee80211/dot11d.c
@@ -62,14 +62,14 @@ void Dot11d_UpdateCountryIe(struct ieee80211_device *dev, u8 *pTaddr,
 	NumTriples = (CoutryIeLen - 3) / 3; /* skip 3-byte country string. */
 	pTriple = (struct chnl_txpower_triple *)(pCoutryIe + 3);
 	for (i = 0; i < NumTriples; i++) {
-		if (MaxChnlNum >= pTriple->FirstChnl) {
+		if (MaxChnlNum >= pTriple->first_channel) {
 			/* It is not in a monotonically increasing order, so
 			 * stop processing.
 			 */
 			netdev_err(dev->dev, "Dot11d_UpdateCountryIe(): Invalid country IE, skip it........1\n");
 			return;
 		}
-		if (MAX_CHANNEL_NUMBER < (pTriple->FirstChnl + pTriple->NumChnls)) {
+		if (MAX_CHANNEL_NUMBER < (pTriple->first_channel + pTriple->NumChnls)) {
 			/* It is not a valid set of channel id, so stop
 			 * processing.
 			 */
@@ -78,9 +78,9 @@ void Dot11d_UpdateCountryIe(struct ieee80211_device *dev, u8 *pTaddr,
 		}
 
 		for (j = 0; j < pTriple->NumChnls; j++) {
-			pDot11dInfo->channel_map[pTriple->FirstChnl + j] = 1;
-			pDot11dInfo->MaxTxPwrDbmList[pTriple->FirstChnl + j] = pTriple->MaxTxPowerInDbm;
-			MaxChnlNum = pTriple->FirstChnl + j;
+			pDot11dInfo->channel_map[pTriple->first_channel + j] = 1;
+			pDot11dInfo->MaxTxPwrDbmList[pTriple->first_channel + j] = pTriple->MaxTxPowerInDbm;
+			MaxChnlNum = pTriple->first_channel + j;
 		}
 
 		pTriple = (struct chnl_txpower_triple *)((u8 *)pTriple + 3);
diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h b/drivers/staging/rtl8192u/ieee80211/dot11d.h
index 9471279cf8e6..968c622137df 100644
--- a/drivers/staging/rtl8192u/ieee80211/dot11d.h
+++ b/drivers/staging/rtl8192u/ieee80211/dot11d.h
@@ -5,7 +5,7 @@
 #include "ieee80211.h"
 
 struct chnl_txpower_triple {
-	u8 FirstChnl;
+	u8  first_channel;
 	u8  NumChnls;
 	u8  MaxTxPowerInDbm;
 };
-- 
2.18.0


  parent reply	other threads:[~2018-07-20 20:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 20:21 [PATCH 00/14] staging:rtl8192u: Coding style changes John Whitmore
2018-07-20 20:21 ` [PATCH 01/14] staging:rtl8192u: Remove multiple blank lines - Style John Whitmore
2018-07-20 20:21 ` [PATCH 02/14] staging:rtl8192u: Remove typedef from structure " John Whitmore
2018-07-20 20:21 ` John Whitmore [this message]
2018-07-20 20:21 ` [PATCH 04/14] staging:rtl8192u: Rename variable NumChnls " John Whitmore
2018-07-20 20:21 ` [PATCH 05/14] staging:rtl8192u: Rename variable MaxTxPowerInDbm " John Whitmore
2018-07-20 20:21 ` [PATCH 06/14] staging:rtl8192u: Remove typedef and rename DOT11D_STATE " John Whitmore
2018-07-20 20:21 ` [PATCH 07/14] staging:rtl8192u: Remove typedef and rename struct RT_DOT11D_INFO " John Whitmore
2018-07-21  7:00   ` Greg KH
2018-07-20 20:21 ` [PATCH 08/14] staging:rtl8192u: Rename bEnabled > enabled " John Whitmore
2018-07-20 20:21 ` [PATCH 09/14] staging:rtl8192u: Rename CountryIeLen > country_ie_len " John Whitmore
2018-07-20 20:21 ` [PATCH 10/14] staging:rtl8192u: Rename CountryIeBuf > country_ie_buf " John Whitmore
2018-07-20 20:21 ` [PATCH 11/14] staging:rtl8192u: Rename CountryIeSrcAddr > country_ie_src_addr " John Whitmore
2018-07-20 20:21 ` [PATCH 12/14] staging:rtl8192u: Rename CountryIeWatchdog > country_ie_watchdog " John Whitmore
2018-07-20 20:21 ` [PATCH 13/14] staging:rtl8192u: Rename MaxTxPwrDbmList > max_tx_pwr_dbm_list " John Whitmore
2018-07-20 20:21 ` [PATCH 14/14] staging:rtl8192u: Rename variable State > state " John Whitmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180720202142.26312-4-johnfwhitmore@gmail.com \
    --to=johnfwhitmore@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).