From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D85EDECDFBB for ; Fri, 20 Jul 2018 19:25:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88A3C20661 for ; Fri, 20 Jul 2018 19:25:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88A3C20661 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388407AbeGTUPP (ORCPT ); Fri, 20 Jul 2018 16:15:15 -0400 Received: from mail.bootlin.com ([62.4.15.54]:34714 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388036AbeGTUPP (ORCPT ); Fri, 20 Jul 2018 16:15:15 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 6097C20731; Fri, 20 Jul 2018 21:25:33 +0200 (CEST) Received: from bbrezillon (unknown [37.173.220.171]) by mail.bootlin.com (Postfix) with ESMTPSA id 1B1462069C; Fri, 20 Jul 2018 21:25:22 +0200 (CEST) Date: Fri, 20 Jul 2018 21:25:21 +0200 From: Boris Brezillon To: Janusz Krzysztofik Cc: Miquel Raynal , Tony Lindgren , Aaro Koskinen , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Linus Walleij , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Artem Bityutskiy Subject: Re: [RFC PATCH 0/8] mtd: rawnand: ams-delta: Use gpio-omap accessors for data I/O Message-ID: <20180720212521.483d27a5@bbrezillon> In-Reply-To: <6335220.Jscgez8sxx@z50> References: <20180718235710.18242-1-jmkrzyszt@gmail.com> <20180719081508.5dafebde@bbrezillon> <6335220.Jscgez8sxx@z50> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Jul 2018 19:55:42 +0200 Janusz Krzysztofik wrote: > Hi Boris, > > On Thursday, July 19, 2018 8:15:08 AM CEST Boris Brezillon wrote: > > Hi Janusz, > > > > On Thu, 19 Jul 2018 01:57:02 +0200 > > Janusz Krzysztofik wrote: > > > > > Implement the idea suggested by Artem Bityutskiy and Tony Lindgren > > > described in commit b027274d2e3a ("mtd: ams-delta: fix > > > request_mem_region() failure"). > > > > Thanks for doing that. I'll review the patches, but I already have a > > extra request: can you convert this driver to ->exec_op()? It does not > > necessarily have to be done in this patchset, but, that'd be great to > > have one more driver converted to the new interface. > > OK, I'll have a look as my free time permits. > > > BTW, there seems to be a nand_gpio driver, maybe we should merge > > ams-delta code into nand_gpio after it's been patched to use the GPIO > > consumer API. > > nand_gpio uses a form of read()/write() on a single bidirectional register for > data transfer, not GPIO, and it does not make use of NRE / NWE signals. Maybe > the two drivers could be merged to some extent but not entirely, I think. Well, yes, right now the nand-gpio driver is assuming the data bus is not bit-banged, but that's something we can easily add. Anyway, my remark was more a "nice to have" not a hard requirement.