From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B07ECDFBD for ; Sat, 21 Jul 2018 13:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA44620856 for ; Sat, 21 Jul 2018 13:35:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F/vVcIJB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA44620856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728539AbeGUO2U (ORCPT ); Sat, 21 Jul 2018 10:28:20 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:42546 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728351AbeGUO2T (ORCPT ); Sat, 21 Jul 2018 10:28:19 -0400 Received: by mail-pl0-f65.google.com with SMTP id z7-v6so4576448plo.9 for ; Sat, 21 Jul 2018 06:35:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ubexO41eU5i6ImnFrQXEb0OCgTpDP6HhIWS2okH8gp4=; b=F/vVcIJBXjIBv7SBFsRz1pMB7Uro8j6O7D2zARZxhAWJzUGIyeJKZjjzWlStRa7SIs Y4AgtxsxOKs4lPFWWXgJxSI/cW6Q7vbVvda6/vgQ03FgkjFCyumQ8TcudTRfbSo/xGIB OdjYw4orOnsnm/cmddiF1WEKsitEinbViCZx6GiPWeqm15F6UF7I8kEFOnJDG7AZNHdK usDb0ea7MGBFB4l73kuuWiSInhjmUawIotU16VSQir33jCXemxTsnAc+qjXEC1E+8w/R GGJi71tHOPngTgViDq29brfXRvFk7OYbGEpbj/gbTWRUsBEIkY68f5sVjIIp/deWflR7 /6+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ubexO41eU5i6ImnFrQXEb0OCgTpDP6HhIWS2okH8gp4=; b=QWfSwZSR7k03YmeDVr8+RR22AUedfExiNds4HYgjVg0R9DdXahvCr17hdbHCnnn7I9 6hbBLWxemtW3FGWCBSWyVygjqKCNpRqg93Qq+OHWZG04PjQ9isVsDadoKbgNjuI5ClZh Wmy2ogywOQSaS2jABwDhAMDaLeRSiOzBfSk8t8fRk7gM1aeAS5ZSrDOy+GqbXcu/kPaz +Cs4WKI4jjrcCE3h8yd1PXnLzT6u0G6eKVHEy+ckX+Wf6QGN13TbPVLl0mh0hO3w1VMY d1W8mxjBEm1dRhxQ4qFlcUVfZ5HzFmLlZ8D+wRrb6LCYQ6mHcnWE//dEJJRe5QuBv6uE V99A== X-Gm-Message-State: AOUpUlEgkkvh3/xun3yr11/9aP3TEN75cz1kC7+hpJMWaTGd6+05VzzG OyUpglpHhwI+r4Be0C6LxtM= X-Google-Smtp-Source: AAOMgpeB4Wdd+a4ZueLz4sNCliLmIv176f+DgYRwsGPwJmCAL2SZZG9PnFJU3+CuZluFuzTM8cZKOQ== X-Received: by 2002:a17:902:8215:: with SMTP id x21-v6mr5847386pln.175.1532180131634; Sat, 21 Jul 2018 06:35:31 -0700 (PDT) Received: from toddpoynor2.mtv.corp.google.com ([2620:0:1000:3701:7d29:cd13:d903:7908]) by smtp.gmail.com with ESMTPSA id p26-v6sm9445023pfi.183.2018.07.21.06.35.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 06:35:31 -0700 (PDT) From: Todd Poynor To: Rob Springer , John Joseph , Ben Chan , Greg Kroah-Hartman Cc: Zhongze Hu , Dmitry Torokhov , Guenter Roeck , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Todd Poynor Subject: [PATCH 12/14] staging: gasket: page table: convert various logs to debug level Date: Sat, 21 Jul 2018 06:35:05 -0700 Message-Id: <20180721133507.95599-13-toddpoynor@gmail.com> X-Mailer: git-send-email 2.18.0.233.g985f88cf7e-goog In-Reply-To: <20180721133507.95599-1-toddpoynor@gmail.com> References: <20180721133507.95599-1-toddpoynor@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Todd Poynor Debugging information is improperly logged at non-debug log level in a number of places, and some logs regarding error conditions may be generated too frequently, such that these could cause performance problems and/or obscure other logs. Convert these to debug log level. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket/gasket_page_table.c index 9f8116112e0ac..f0c4884cb4bc6 100644 --- a/drivers/staging/gasket/gasket_page_table.c +++ b/drivers/staging/gasket/gasket_page_table.c @@ -306,7 +306,7 @@ int gasket_page_table_init( * hardware register that contains the page table size. */ if (total_entries == ULONG_MAX) { - gasket_nodev_error( + gasket_nodev_debug( "Error reading page table size. " "Initializing page table with size 0."); total_entries = 0; @@ -323,7 +323,7 @@ int gasket_page_table_init( *ppg_tbl = kzalloc(sizeof(**ppg_tbl), GFP_KERNEL); if (!*ppg_tbl) { - gasket_nodev_error("No memory for page table."); + gasket_nodev_debug("No memory for page table."); return -ENOMEM; } @@ -332,7 +332,7 @@ int gasket_page_table_init( if (bytes != 0) { pg_tbl->entries = vmalloc(bytes); if (!pg_tbl->entries) { - gasket_nodev_error( + gasket_nodev_debug( "No memory for address translation metadata."); kfree(pg_tbl); *ppg_tbl = NULL; @@ -658,7 +658,7 @@ int gasket_page_table_system_status(struct gasket_page_table *page_table) } if (gasket_page_table_num_entries(page_table) == 0) { - gasket_nodev_error("Page table size is 0."); + gasket_nodev_debug("Page table size is 0."); return GASKET_STATUS_LAMED; } @@ -903,7 +903,7 @@ static int gasket_perform_mapping( (unsigned long long)ptes[i].dma_addr); if (ptes[i].dma_addr == -1) { - gasket_nodev_error( + gasket_nodev_debug( "%s i %d" " -> fail to map page %llx " "[pfn %p ohys %p]\n", @@ -1612,7 +1612,7 @@ int gasket_set_user_virt( */ pg_tbl = gasket_dev->page_table[0]; if (!pg_tbl) { - gasket_nodev_error( + gasket_nodev_debug( "%s: invalid page table index", __func__); return 0; } -- 2.18.0.233.g985f88cf7e-goog