From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9340BECDE5F for ; Sat, 21 Jul 2018 16:33:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B8D720858 for ; Sat, 21 Jul 2018 16:33:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="aIcEWogr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B8D720858 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728166AbeGUR0y (ORCPT ); Sat, 21 Jul 2018 13:26:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:43636 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727876AbeGUR0x (ORCPT ); Sat, 21 Jul 2018 13:26:53 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 73EB420856; Sat, 21 Jul 2018 16:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1532190815; bh=fc3TRF9QOYytd1b7vPG/Ckbs5/0K1A1n549haCV8emU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aIcEWogrjeiZKWwld9itLtKCkII8KxzSVvfd+7HsBEzka5mkwLhOkc2cyOHp/kkSA hjovI24saDTrKHBT93+kt6yjIm381Rg2/ipN9d96JWcXIcSEkgm0f90L0UGyVlHPXU WRcQD3w39voBsKYWQGTKgyyqx9MeJtt5dgRK2A0s= Date: Sat, 21 Jul 2018 17:33:30 +0100 From: Jonathan Cameron To: Joe Perches Cc: Michal Simek , Lars-Peter Clausen , Manish Narani , knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, anirudh@xilinx.com, sgoud@xilinx.com Subject: Re: [PATCH 1/4] iio: adc: xilinx: Rename 'channels' variable name to 'iio_xadc_channels' Message-ID: <20180721173330.764ede75@archlinux> In-Reply-To: <070dda6dd3b140ef5f6dbc965d7f8c1af934ec96.camel@perches.com> References: <1531912331-26431-1-git-send-email-manish.narani@xilinx.com> <1531912331-26431-2-git-send-email-manish.narani@xilinx.com> <7c4ee0db-ac33-b093-4dbb-1742fb029012@xilinx.com> <20180721171828.55395acc@archlinux> <070dda6dd3b140ef5f6dbc965d7f8c1af934ec96.camel@perches.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 21 Jul 2018 09:22:05 -0700 Joe Perches wrote: > On Sat, 2018-07-21 at 17:18 +0100, Jonathan Cameron wrote: > > On Thu, 19 Jul 2018 10:22:07 +0200 > > Michal Simek wrote: > > > > > On 18.7.2018 13:18, Lars-Peter Clausen wrote: > > > > On 07/18/2018 01:12 PM, Manish Narani wrote: > > > > > This patch fix the following checkpatch warning in xadc driver. > > > > > - Reusing the krealloc arg is almost always a bug. > > > > > > > > > > Renamed the 'channels' variable as 'iio_xadc_channels' to fix the above > > > > > warning. > > > > > > > > > > > > > This is a bug in checkpatch and should be fixed in checkpatch. The code is > > > > not actually re-using the parameter. channels and xadc_channels are > > > > independent variables, just checkpatch somehow does not realize this. > > > > > > I think it should be fine to have this patch in tree. Change in commit > > > message to reflect this should be enough. But that's just view. > > > > Let's wait and see if Joe has time to take a look at this. Might be better > > to fix checkpatch if it's not too hard! > > I submitted a proposed patch. > I believe it works. > > https://patchwork.kernel.org/patch/10533011/ > Thanks! Should have known you would already have it covered :) My perl foo goes no where near figuring out how that magic works! Jonathan