public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "M. Vefa Bicakci" <m.v.b@runbox.com>
To: linux-kernel@vger.kernel.org
Cc: "M . Vefa Bicakci" <m.v.b@runbox.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org, x86@kernel.org,
	stable@vger.kernel.org
Subject: [PATCH 2/2] xen/pv: Call get_cpu_address_sizes to set x86_virt/phys_bits
Date: Sat, 21 Jul 2018 15:49:09 -0400	[thread overview]
Message-ID: <20180721194909.23903-2-m.v.b@runbox.com> (raw)
In-Reply-To: <20180721194909.23903-1-m.v.b@runbox.com>

Commit d94a155c59c9 ("x86/cpu: Prevent cpuinfo_x86::x86_phys_bits
adjustment corruption") has moved the query and calculation of the
"x86_virt_bits" and "x86_phys_bits" fields of the "cpuinfo_x86" struct
from the "get_cpu_cap" function to a new function named
"get_cpu_address_sizes".

One of the call sites related to Xen PV VMs was unfortunately missed
in the aforementioned commit, and this prevents successful boot-up of
kernel versions 4.17 and up in Xen PV VMs.

Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org
Cc: x86@kernel.org
Cc: stable@vger.kernel.org # for v4.17 and up
Fixes: d94a155c59c9 ("x86/cpu: Prevent cpuinfo_x86::x86_phys_bits adjustment corruption")
---
 arch/x86/kernel/cpu/common.c | 2 +-
 arch/x86/kernel/cpu/cpu.h    | 1 +
 arch/x86/xen/enlighten_pv.c  | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index eb4cb3efd20e..2322d0c4bfd2 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -911,7 +911,7 @@ void get_cpu_cap(struct cpuinfo_x86 *c)
 	apply_forced_caps(c);
 }
 
-static void get_cpu_address_sizes(struct cpuinfo_x86 *c)
+void get_cpu_address_sizes(struct cpuinfo_x86 *c)
 {
 	u32 eax, ebx, ecx, edx;
 
diff --git a/arch/x86/kernel/cpu/cpu.h b/arch/x86/kernel/cpu/cpu.h
index 38216f678fc3..12a5f0cec0b2 100644
--- a/arch/x86/kernel/cpu/cpu.h
+++ b/arch/x86/kernel/cpu/cpu.h
@@ -46,6 +46,7 @@ extern const struct cpu_dev *const __x86_cpu_dev_start[],
 			    *const __x86_cpu_dev_end[];
 
 extern void get_cpu_cap(struct cpuinfo_x86 *c);
+extern void get_cpu_address_sizes(struct cpuinfo_x86 *c);
 extern void cpu_detect_cache_sizes(struct cpuinfo_x86 *c);
 extern void init_scattered_cpuid_features(struct cpuinfo_x86 *c);
 extern u32 get_scattered_cpuid_leaf(unsigned int level,
diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 439a94bf89ad..87afb000142a 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -1257,6 +1257,7 @@ asmlinkage __visible void __init xen_start_kernel(void)
 
 	/* Work out if we support NX */
 	get_cpu_cap(&boot_cpu_data);
+	get_cpu_address_sizes(&boot_cpu_data);
 	x86_configure_nx();
 
 	/* Let's presume PV guests always boot on vCPU with id 0. */
-- 
2.17.1


  reply	other threads:[~2018-07-21 20:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-21 19:49 [PATCH 1/2] x86/entry/64: Do not clear %rbx under Xen M. Vefa Bicakci
2018-07-21 19:49 ` M. Vefa Bicakci [this message]
2018-07-21 21:25   ` [PATCH 2/2] xen/pv: Call get_cpu_address_sizes to set x86_virt/phys_bits Boris Ostrovsky
2018-07-21 23:17     ` M. Vefa Bicakci
2018-07-22 15:57       ` M. Vefa Bicakci
2018-07-23 15:04         ` Boris Ostrovsky
2018-07-24 12:42           ` M. Vefa Bicakci
2018-07-24 12:45   ` [PATCH v2] " M. Vefa Bicakci
2018-07-24 14:08     ` Boris Ostrovsky
2018-07-26  3:56     ` [PATCH v3] " M. Vefa Bicakci
2018-08-06 20:15     ` [PATCH v2] " Boris Ostrovsky
2018-08-06 20:16       ` Thomas Gleixner
2018-08-06 21:27         ` Boris Ostrovsky
2018-08-07  9:50       ` Ingo Molnar
2018-07-21 21:19 ` [PATCH 1/2] x86/entry/64: Do not clear %rbx under Xen Boris Ostrovsky
2018-07-21 23:18   ` M. Vefa Bicakci
2018-07-23 14:56     ` Boris Ostrovsky
2018-07-21 21:45 ` Andy Lutomirski
2018-07-21 23:19   ` M. Vefa Bicakci
2018-07-21 23:30     ` Andy Lutomirski
2018-07-21 23:37       ` M. Vefa Bicakci
2018-07-22  1:20         ` M. Vefa Bicakci
2018-07-22 17:56           ` Andy Lutomirski
2018-07-22 18:32             ` [Xen-devel] " Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180721194909.23903-2-m.v.b@runbox.com \
    --to=m.v.b@runbox.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox