From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19536ECDE5F for ; Sun, 22 Jul 2018 03:12:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F3C520856 for ; Sun, 22 Jul 2018 03:12:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F3C520856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727207AbeGVEGs (ORCPT ); Sun, 22 Jul 2018 00:06:48 -0400 Received: from mga17.intel.com ([192.55.52.151]:53831 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726827AbeGVEGr (ORCPT ); Sun, 22 Jul 2018 00:06:47 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jul 2018 20:11:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,387,1526367600"; d="scan'208";a="217992805" Received: from theros.lm.intel.com (HELO linux.intel.com) ([10.232.112.164]) by orsmga004.jf.intel.com with ESMTP; 21 Jul 2018 20:11:44 -0700 Date: Sat, 21 Jul 2018 21:11:44 -0600 From: Ross Zwisler To: Dave Chinner Cc: Matthew Wilcox , Ross Zwisler , kbuild test robot , kbuild-all@01.org, Andrew Morton , linux-kernel@vger.kernel.org, Christoph Hellwig , Dan Williams , Jan Kara , linux-nvdimm@lists.01.org Subject: Re: [PATCH 1/5] radix tree test suite: fix mapshift build target Message-ID: <20180722031144.GA12948@linux.intel.com> References: <20180503192430.7582-1-ross.zwisler@linux.intel.com> <20180503192430.7582-2-ross.zwisler@linux.intel.com> <20180715230052.GA6486@bombadil.infradead.org> <20180716160710.GA2287@linux.intel.com> <20180716195249.GA14380@bombadil.infradead.org> <20180716210820.GA17164@linux.intel.com> <20180717024132.GC7934@bombadil.infradead.org> <20180721234550.GB1691@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180721234550.GB1691@dastard> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 22, 2018 at 09:45:50AM +1000, Dave Chinner wrote: > On Mon, Jul 16, 2018 at 07:41:32PM -0700, Matthew Wilcox wrote: > > On Mon, Jul 16, 2018 at 03:08:20PM -0600, Ross Zwisler wrote: > > > On Mon, Jul 16, 2018 at 12:52:49PM -0700, Matthew Wilcox wrote: > > > > On Mon, Jul 16, 2018 at 10:07:10AM -0600, Ross Zwisler wrote: > > > <> > > > > OK ... what version of make are you using? Because this works fine for me: > > > > > > > > $ git clone linux clean > > > > $ cd clean > > > > $ git checkout v4.17 > > > > $ cd tools/testing/radix-tree/ > > > > $ git revert 8d9fa88edd5e360b71765feeadb915d4066c9684 > > > > $ make > > > > > > > > $ make --version > > > > GNU Make 4.1 > > > > Built for x86_64-pc-linux-gnu > > > > > > > > It's Debian's Version: 4.1-9.1 > > > > > > $ make --version > > > GNU Make 4.2.1 > > > Built for x86_64-redhat-linux-gnu > > > > > > The one from Fedora 27. > > > > Huh. I just tried 4.2.1-1.1 from Debian unstable and that doesn't > > produce the problem either. I'm not sure how to proceed at this point. > > I'm really not a makefile expert. > > This smells like a problem we just hit with make 4.2.1 in fedora 28 > in fstests - the regex expanstion has been screwed up such that > things like [a-z] will match [A-Z] and other things as well. Debian > is unaffected, apparently fedora has a backport of stuff from the > as-yet-unreleased next version of make/glibc. See this thread: > > https://www.spinics.net/lists/fstests/msg10200.html > > Try setting LANG=C and seeing if the problem goes away.... Hey Dave, we root caused this difference to to be the fact that I had 'make' aliased to 'make -j32' in my .bashrc. Matthew was running a singled threaded build, while I was running a multi-threaded one. When Matthew ran a multi-threaded build, he was able to reproduce the issue. So, essentially I think that the makefile just needs to be enhanced so that all the dependencies are explicit to allow multi-threaded builds to work properly.