public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: jarkko.sakkinen@linux.intel.com, linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm: add support for partial reads
Date: Mon, 23 Jul 2018 15:48:46 -0600	[thread overview]
Message-ID: <20180723214846.GG532@ziepe.ca> (raw)
In-Reply-To: <153201555276.20155.1352499992826895966.stgit@tstruk-mobl1.jf.intel.com>

On Thu, Jul 19, 2018 at 08:52:32AM -0700, Tadeusz Struk wrote:
> Currently to read a response from the TPM device an application needs
> provide "big enough" buffer for the whole response and read it in one go.
> The application doesn't know how big the response it beforehand so it
> always needs to maintain a 4K buffer and read the max (4K).
> In case if the user of the TSS library doesn't provide big enough buffer
> the TCTI spec says that the library should set the required size and return
> TSS2_TCTI_RC_INSUFFICIENT_BUFFER error code so that the application could
> allocate a bigger buffer and call receive again.
> To make it possible in the TSS library this requires being able to do
> partial reads from the driver.
> The library would read the header first to get the actual size of the
> response from the header and then read the rest of the response.
> This patch adds support for partial reads.

You should solve this in user space, the kernel API requires a full
sized buffer here, the tss library should always provide such an
internal buffer and then implement whatever scheme TSS wants by
memcpying from that buffer..

Jason

      parent reply	other threads:[~2018-07-23 21:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 15:52 [PATCH] tpm: add support for partial reads Tadeusz Struk
2018-07-19 15:55 ` Tadeusz Struk
2018-07-19 17:19 ` James Bottomley
2018-07-19 17:54   ` Tadeusz Struk
2018-07-19 18:47     ` James Bottomley
2018-07-19 19:05       ` Tadeusz Struk
2018-07-19 19:52         ` James Bottomley
2018-07-19 20:12           ` Tadeusz Struk
2018-07-19 20:27             ` James Bottomley
2018-07-19 21:01               ` Tadeusz Struk
2018-07-23 20:19 ` Jarkko Sakkinen
2018-07-23 20:53   ` Tadeusz Struk
2018-07-23 21:13     ` James Bottomley
2018-07-23 21:38       ` Tadeusz Struk
2018-07-23 21:56         ` Jason Gunthorpe
2018-07-23 22:00           ` Tadeusz Struk
2018-07-23 22:08             ` Jason Gunthorpe
2018-07-23 23:42               ` Tadeusz Struk
2018-07-24  2:05                 ` Jason Gunthorpe
2018-07-23 21:48 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180723214846.GG532@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=tadeusz.struk@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox