From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jacopo Mondi <jacopo@jmondi.org>, Christoph Hellwig <hch@lst.de>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Linux-sh list <linux-sh@vger.kernel.org>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
lkp@intel.com
Subject: Re: [PATCH 4/5] sh: split arch/sh/mm/consistent.c
Date: Tue, 24 Jul 2018 13:43:34 +0200 [thread overview]
Message-ID: <20180724114334.GA21973@lst.de> (raw)
In-Reply-To: <CAMuHMdX=b0iAnDw1=85MXNBSMD=MxZb27QrO3rEWHYq0vB+3ow@mail.gmail.com>
On Mon, Jul 23, 2018 at 10:49:39AM +0200, Geert Uytterhoeven wrote:
> > > + *dma_handle = virt_to_phys(ret);
> > > + if (!WARN_ON(!dev))
> > > + *dma_handle - PFN_PHYS(dev->dma_pfn_offset);
> > vs
> > > - *dma_handle = virt_to_phys(ret);
> > > - if (!WARN_ON(!dev))
> > > - *dma_handle -= PFN_PHYS(dev->dma_pfn_offset);
>
> Doesn't look right to me, neither.
>
> No complaints for 0day? My gcc says:
>
> error: statement with no effect [-Werror=unused-value]
For some reason 0day has failed me multiple times for sh. Does the
0day bot even cover sh at all?
next prev parent reply other threads:[~2018-07-24 11:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 13:05 use the generic dma-noncoherent code for sh Christoph Hellwig
2018-07-19 13:05 ` [PATCH 1/5] sh: simplify get_arch_dma_ops Christoph Hellwig
2018-07-19 13:05 ` [PATCH 2/5] sh: introduce a sh_cacheop_vaddr helper Christoph Hellwig
2018-07-19 13:05 ` [PATCH 3/5] sh: use dma_direct_ops for the CONFIG_DMA_COHERENT case Christoph Hellwig
2018-07-19 13:05 ` [PATCH 4/5] sh: split arch/sh/mm/consistent.c Christoph Hellwig
2018-07-23 8:42 ` jacopo mondi
2018-07-23 8:49 ` Geert Uytterhoeven
2018-07-24 11:43 ` Christoph Hellwig [this message]
2018-07-24 12:11 ` Li, Philip
2018-07-19 13:05 ` [PATCH 5/5] sh: use generic dma_noncoherent_ops Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2018-07-24 12:01 use the generic dma-noncoherent code for sh V2 Christoph Hellwig
2018-07-24 12:01 ` [PATCH 4/5] sh: split arch/sh/mm/consistent.c Christoph Hellwig
2018-07-25 9:40 use the generic dma-noncoherent code for sh V3 Christoph Hellwig
2018-07-25 9:40 ` [PATCH 4/5] sh: split arch/sh/mm/consistent.c Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724114334.GA21973@lst.de \
--to=hch@lst.de \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacopo+renesas@jmondi.org \
--cc=jacopo@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lkp@intel.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox