public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andreas Noever <andreas.noever@gmail.com>,
	Michael Jamet <michael.jamet@intel.com>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] thunderbolt: Add support for runtime PM
Date: Wed, 25 Jul 2018 10:17:01 +0200	[thread overview]
Message-ID: <20180725081701.GA16930@kroah.com> (raw)
In-Reply-To: <20180725080321.35746-7-mika.westerberg@linux.intel.com>

On Wed, Jul 25, 2018 at 11:03:20AM +0300, Mika Westerberg wrote:
> When Thunderbolt host controller is set to RTD3 mode (Runtime D3) it is
> present all the time. Because of this it is important to runtime suspend
> the controller whenever possible. In case of ICM we have following rules
> which all needs to be true before the host controller can be put to D3:
> 
>   - The controller firmware reports to support RTD3
>   - All the connected devices announce support for RTD3
>   - There is no active XDomain connection
> 
> Implement this using standard Linux runtime PM APIs so that when all the
> children devices are runtime suspended, the Thunderbolt host controller
> PCI device is runtime suspended as well. The ICM firmware then starts
> powering down power domains towards RTD3 but it can prevent this if it
> detects that there is an active Display Port stream (this is not visible
> to the software, though).
> 
> The Thunderbolt host controller will be runtime resumed either when
> there is a remote wake event (device is connected or disconnected), or
> when there is access from userspace that requires hardware access.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
>  drivers/thunderbolt/domain.c  |  42 +++++++++++-
>  drivers/thunderbolt/icm.c     | 119 ++++++++++++++++++++++++++++++----
>  drivers/thunderbolt/nhi.c     |  38 ++++++++++-
>  drivers/thunderbolt/switch.c  |  65 +++++++++++++++++--
>  drivers/thunderbolt/tb.h      |  10 +++
>  drivers/thunderbolt/tb_msgs.h |   4 ++
>  drivers/thunderbolt/xdomain.c |  18 +++++
>  7 files changed, 276 insertions(+), 20 deletions(-)


This patch did not apply to my tree at all, what branch did you make it
against?

I've applied the others here, thanks.

greg k-h

  reply	other threads:[~2018-07-25  8:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25  8:03 [PATCH 0/7] thunderbolt: Changes for v4.19 merge window Mika Westerberg
2018-07-25  8:03 ` [PATCH 1/7] thunderbolt: Fix small typo in variable name Mika Westerberg
2018-07-25  8:03 ` [PATCH 2/7] thunderbolt: Use 64-bit DMA mask if supported by the platform Mika Westerberg
2018-07-25  8:03 ` [PATCH 3/7] thunderbolt: Do not unnecessarily call ICM get route Mika Westerberg
2018-07-25  8:03 ` [PATCH 4/7] thunderbolt: No need to take tb->lock in domain suspend/complete Mika Westerberg
2018-07-25  8:03 ` [PATCH 5/7] thunderbolt: Use correct ICM commands in system suspend Mika Westerberg
2018-07-25  8:03 ` [PATCH 6/7] thunderbolt: Add support for runtime PM Mika Westerberg
2018-07-25  8:17   ` Greg Kroah-Hartman [this message]
2018-07-25  8:43     ` Mika Westerberg
2018-07-25  8:48   ` [PATCH v2 " Mika Westerberg
2018-07-25  8:03 ` [PATCH 7/7] thunderbolt: Remove redundant variable 'approved' Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180725081701.GA16930@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox