linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers: infiniband: core: Remove extra parentheses
@ 2018-07-25 18:43 Varsha Rao
  2018-07-25 20:37 ` Jason Gunthorpe
  0 siblings, 1 reply; 2+ messages in thread
From: Varsha Rao @ 2018-07-25 18:43 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe, Lukas Bulwahn, Nicholas Mc Guire,
	linux-rdma, linux-kernel
  Cc: Varsha Rao

Remove unnecessary parentheses to fix the clang warning of extraneous
parentheses.

Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
 drivers/infiniband/core/cma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index bff10ab141b0..c200a2e748f0 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -4010,7 +4010,7 @@ static void cma_set_mgid(struct rdma_id_private *id_priv,
 		memcpy(mgid, &sin6->sin6_addr, sizeof *mgid);
 	} else if (addr->sa_family == AF_IB) {
 		memcpy(mgid, &((struct sockaddr_ib *) addr)->sib_addr, sizeof *mgid);
-	} else if ((addr->sa_family == AF_INET6)) {
+	} else if (addr->sa_family == AF_INET6) {
 		ipv6_ib_mc_map(&sin6->sin6_addr, dev_addr->broadcast, mc_map);
 		if (id_priv->id.ps == RDMA_PS_UDP)
 			mc_map[7] = 0x01;	/* Use RDMA CM signature */
-- 
2.17.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers: infiniband: core: Remove extra parentheses
  2018-07-25 18:43 [PATCH] drivers: infiniband: core: Remove extra parentheses Varsha Rao
@ 2018-07-25 20:37 ` Jason Gunthorpe
  0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2018-07-25 20:37 UTC (permalink / raw)
  To: Varsha Rao
  Cc: Doug Ledford, Lukas Bulwahn, Nicholas Mc Guire, linux-rdma,
	linux-kernel

On Wed, Jul 25, 2018 at 08:43:56PM +0200, Varsha Rao wrote:
> Remove unnecessary parentheses to fix the clang warning of extraneous
> parentheses.
> 
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
>  drivers/infiniband/core/cma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Curious, what configuration are you using clang with? I'd like to have
it run here..

Jason

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-25 20:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-25 18:43 [PATCH] drivers: infiniband: core: Remove extra parentheses Varsha Rao
2018-07-25 20:37 ` Jason Gunthorpe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).