From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0661C6778F for ; Thu, 26 Jul 2018 17:17:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8AD1F20647 for ; Thu, 26 Jul 2018 17:17:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AD1F20647 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388790AbeGZSfn (ORCPT ); Thu, 26 Jul 2018 14:35:43 -0400 Received: from verein.lst.de ([213.95.11.211]:37396 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730085AbeGZSfm (ORCPT ); Thu, 26 Jul 2018 14:35:42 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 3DF9168D62; Thu, 26 Jul 2018 19:21:43 +0200 (CEST) Date: Thu, 26 Jul 2018 19:21:43 +0200 From: Christoph Hellwig To: Masahiro Yamada Cc: Christoph Hellwig , Randy Dunlap , Richard Weinberger , Ley Foon Tan , Michal Simek , Linux Kbuild mailing list , linux-um@lists.infradead.org, linux-arch@lists.infradead.org, Linux Kernel Mailing List Subject: Re: include architecture Kconfig files from top-level Kconfig v3 Message-ID: <20180726172143.GA9836@lst.de> References: <20180724175646.3621-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 25, 2018 at 01:30:24PM +0900, Masahiro Yamada wrote: > Could you check the difference of CONFIG_PREEMPT_COUNT, please? > > > For alpha, hexagon, um, > CONFIG_PREEMPT_COUNT was previously never enabled > because kernel/Kconfig.preempt was not included. > > Now, CONFIG_PREEMPT_COUNT can be enabled > if it is select'ed by someone. > > I guess this change will be OK, but > I'd like you and Randy to double-check it just in case. It might be fine, but with this little fix folded in we should be safer: diff --git a/kernel/Kconfig.preempt b/kernel/Kconfig.preempt index cd1655122ec0..1321a4a7a677 100644 --- a/kernel/Kconfig.preempt +++ b/kernel/Kconfig.preempt @@ -57,4 +57,5 @@ config PREEMPT endchoice config PREEMPT_COUNT - bool \ No newline at end of file + depends on !ARCH_NO_PREEMPT + bool