From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E6FC67790 for ; Fri, 27 Jul 2018 07:45:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 366B620673 for ; Fri, 27 Jul 2018 07:45:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 366B620673 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730142AbeG0JFm (ORCPT ); Fri, 27 Jul 2018 05:05:42 -0400 Received: from verein.lst.de ([213.95.11.211]:39928 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729498AbeG0JFm (ORCPT ); Fri, 27 Jul 2018 05:05:42 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id E023B68D60; Fri, 27 Jul 2018 09:48:54 +0200 (CEST) Date: Fri, 27 Jul 2018 09:48:54 +0200 From: Christoph Hellwig To: Masahiro Yamada Cc: Christoph Hellwig , Randy Dunlap , Richard Weinberger , Ley Foon Tan , Michal Simek , Linux Kbuild mailing list , linux-um@lists.infradead.org, linux-arch@lists.infradead.org, Linux Kernel Mailing List Subject: Re: include architecture Kconfig files from top-level Kconfig v3 Message-ID: <20180727074854.GA21840@lst.de> References: <20180724175646.3621-1-hch@lst.de> <20180726172143.GA9836@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 27, 2018 at 10:32:19AM +0900, Masahiro Yamada wrote: > This will just add a new unmet dependency warning. > CONFIG_PREEMPT_COUNT will be still selected. True. I guess we simply need to prohibit CONFIG_DEBUG_ATOMIC_SLEEP explicitly if PREEMPT_COUNT isn't supported. E.g something like this: diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 26d3ff7e3cf4..373ce9fecd7e 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1195,6 +1195,7 @@ config DEBUG_ATOMIC_SLEEP bool "Sleep inside atomic section checking" select PREEMPT_COUNT depends on DEBUG_KERNEL + depends on !ARCH_NO_PREEMPT help If you say Y here, various routines which may sleep will become very noisy if they are called inside atomic sections: when a spinlock is