From: "Luck, Tony" <tony.luck@intel.com>
To: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
bp@suse.de, x86@kernel.org
Subject: Re: [PATCH] x86/mce: Handle varying MCA bank counts
Date: Fri, 27 Jul 2018 15:08:34 -0700 [thread overview]
Message-ID: <20180727220833.GA30752@agluck-desk> (raw)
In-Reply-To: <20180727214009.78289-1-Yazen.Ghannam@amd.com>
On Fri, Jul 27, 2018 at 04:40:09PM -0500, Yazen Ghannam wrote:
> - /* Don't support asymmetric configurations today */
> - WARN_ON(mca_cfg.banks != 0 && b != mca_cfg.banks);
> - mca_cfg.banks = b;
> + mca_cfg.banks = max(mca_cfg.banks, b);
Should we change mca_cfg.banks to be a per-cpu variable?
DEFINE_PER_CPU(int, mce_num_banks);
That would make it easier to make sure the places
that scan all banks only look at the ones that exist.
-Tony
next prev parent reply other threads:[~2018-07-27 22:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 21:40 [PATCH] x86/mce: Handle varying MCA bank counts Yazen Ghannam
2018-07-27 22:08 ` Luck, Tony [this message]
2018-08-01 15:40 ` Ghannam, Yazen
2019-03-27 12:16 ` [tip:ras/core] " tip-bot for Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727220833.GA30752@agluck-desk \
--to=tony.luck@intel.com \
--cc=Yazen.Ghannam@amd.com \
--cc=bp@suse.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox