From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 02/10] staging:rtl8192u: Refactor use of enum dm_dig_sta_e - Style
Date: Sat, 28 Jul 2018 00:28:18 +0100 [thread overview]
Message-ID: <20180727232826.28014-3-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180727232826.28014-1-johnfwhitmore@gmail.com>
Refactor the use of the enumerated type dm_dig_sta_e, which is not
actually used for type checking by the compiler.
The enumerated type defines values for the enumeration, which are used
by both dig_state and dig_highpwr_state, (members of the struct dig).
Both of those variables were defined as being of type u8. This negates
any usefulness of the use of the enumeration, (compiler type checking).
To make use of the compiler's type-checking the two member variables,
dig_state and dig_highpwr_state have been changed to being of type
enum dm_dig_sta_e. The enumerated type has been moved above the
struct dig definition so that the enumeration is already defined when
compiler reaches the two types using the enumerated type.
In addition the 'typedef' of the enumerated type has been removed to
clear the checkpatch issue with declaring new types.
These changes, whilst convoluted, are purely coding style in nature and
should not impact runtime code execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/r8192U_dm.h | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.h b/drivers/staging/rtl8192u/r8192U_dm.h
index e86dda99c223..2444e1c1357b 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.h
+++ b/drivers/staging/rtl8192u/r8192U_dm.h
@@ -64,6 +64,13 @@
/*------------------------------Define structure----------------------------*/
+
+enum dm_dig_sta_e {
+ DM_STA_DIG_OFF = 0,
+ DM_STA_DIG_ON,
+ DM_STA_DIG_MAX
+};
+
/* 2007/10/04 MH Define upper and lower threshold of DIG enable or disable. */
struct dig {
u8 dig_enable_flag;
@@ -77,8 +84,8 @@ struct dig {
long rssi_high_power_lowthresh;
long rssi_high_power_highthresh;
- u8 dig_state;
- u8 dig_highpwr_state;
+ enum dm_dig_sta_e dig_state;
+ enum dm_dig_sta_e dig_highpwr_state;
u8 cur_connect_state;
u8 pre_connect_state;
@@ -98,13 +105,6 @@ struct dig {
long rssi_val;
};
-typedef enum tag_dynamic_init_gain_state_definition {
- DM_STA_DIG_OFF = 0,
- DM_STA_DIG_ON,
- DM_STA_DIG_MAX
-} dm_dig_sta_e;
-
-
/* 2007/10/08 MH Define RATR state. */
typedef enum tag_dynamic_ratr_state_definition {
DM_RATR_STA_HIGH = 0,
--
2.18.0
next prev parent reply other threads:[~2018-07-27 23:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 23:28 [PATCH 00/10] staging:rtl8192u: Refactor enums r8192U_dm.h -Style John Whitmore
2018-07-27 23:28 ` [PATCH 01/10] staging:rtl8192u: Remove unused DM_check_fsync_time_interval - Style John Whitmore
2018-07-27 23:28 ` John Whitmore [this message]
2018-07-29 8:17 ` [PATCH 02/10] staging:rtl8192u: Refactor use of enum dm_dig_sta_e " Greg KH
2018-07-29 9:50 ` John Whitmore
2018-07-27 23:28 ` [PATCH 03/10] staging:rtl8192u: Refactor enum dm_ratr_sta_e usage " John Whitmore
2018-07-27 23:28 ` [PATCH 04/10] staging:rtl8192u: Remove enum dm_dig_op_e John Whitmore
2018-07-27 23:28 ` [PATCH 05/10] staging:rtl8192u: Refactor enum dm_dig_alg_e - Style John Whitmore
2018-07-27 23:28 ` [PATCH 06/10] staging:rtl8192u: Remove unused enum dm_dig_dbg_e " John Whitmore
2018-07-27 23:28 ` [PATCH 07/10] staging:rtl8192u: Refactor dm_dig_connect_e " John Whitmore
2018-07-27 23:28 ` [PATCH 08/10] staging:rtl8192u: Refactor enum dm_dig_pd_th_e " John Whitmore
2018-07-27 23:28 ` [PATCH 09/10] staging:rtl8192u: Refactor enum dm_dig_cs_ratio_e " John Whitmore
2018-07-27 23:28 ` [PATCH 10/10] staging:rtl8192u: Refactor enum DM_CCK_Rx_Path_Method " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727232826.28014-3-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox