public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 05/10] staging:rtl8192u: Refactor enum dm_dig_alg_e - Style
Date: Sat, 28 Jul 2018 00:28:21 +0100	[thread overview]
Message-ID: <20180727232826.28014-6-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180727232826.28014-1-johnfwhitmore@gmail.com>

The enumerated type dm_dig_alg_e is only used by one variable in the
code, 'dig_algorithm', a member variable of the structure dig. That
member variable was defined to be of type 'u8' thus negating any
advantage of the use of an enumerated type, (compiler type-checking).

The type of the variable 'dig_algorithm' has been change to reflect
its use of the enumeration and the enumerated type moved in the file
so that it appears before it is used in the file.

Additionally the 'typedef' has been removed to clear the checkpatch
issue with defining new types.

These changes are all coding style in nature and as such should have
no impact on runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/r8192U_dm.h | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8192u/r8192U_dm.h b/drivers/staging/rtl8192u/r8192U_dm.h
index 7d7eeb1cb9fc..22e25a5cf40a 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.h
+++ b/drivers/staging/rtl8192u/r8192U_dm.h
@@ -65,6 +65,11 @@
 
 /*------------------------------Define structure----------------------------*/
 
+enum dm_dig_alg_e {
+	DIG_ALGO_BY_FALSE_ALARM = 0,
+	DIG_ALGO_BY_RSSI	= 1,
+};
+
 enum dm_dig_sta_e {
 	DM_STA_DIG_OFF = 0,
 	DM_STA_DIG_ON,
@@ -74,7 +79,7 @@ enum dm_dig_sta_e {
 /* 2007/10/04 MH Define upper and lower threshold of DIG enable or disable. */
 struct dig {
 	u8		dig_enable_flag;
-	u8		dig_algorithm;
+	enum dm_dig_alg_e		dig_algorithm;
 	u8		dbg_mode;
 	u8		dig_algorithm_switch;
 
@@ -105,12 +110,6 @@ struct dig {
 	long		rssi_val;
 };
 
-typedef enum tag_dig_algorithm_definition {
-	DIG_ALGO_BY_FALSE_ALARM = 0,
-	DIG_ALGO_BY_RSSI	= 1,
-	DIG_ALGO_MAX
-} dm_dig_alg_e;
-
 typedef enum tag_dig_dbgmode_definition {
 	DIG_DBG_OFF = 0,
 	DIG_DBG_ON = 1,
-- 
2.18.0


  parent reply	other threads:[~2018-07-27 23:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27 23:28 [PATCH 00/10] staging:rtl8192u: Refactor enums r8192U_dm.h -Style John Whitmore
2018-07-27 23:28 ` [PATCH 01/10] staging:rtl8192u: Remove unused DM_check_fsync_time_interval - Style John Whitmore
2018-07-27 23:28 ` [PATCH 02/10] staging:rtl8192u: Refactor use of enum dm_dig_sta_e " John Whitmore
2018-07-29  8:17   ` Greg KH
2018-07-29  9:50     ` John Whitmore
2018-07-27 23:28 ` [PATCH 03/10] staging:rtl8192u: Refactor enum dm_ratr_sta_e usage " John Whitmore
2018-07-27 23:28 ` [PATCH 04/10] staging:rtl8192u: Remove enum dm_dig_op_e John Whitmore
2018-07-27 23:28 ` John Whitmore [this message]
2018-07-27 23:28 ` [PATCH 06/10] staging:rtl8192u: Remove unused enum dm_dig_dbg_e - Style John Whitmore
2018-07-27 23:28 ` [PATCH 07/10] staging:rtl8192u: Refactor dm_dig_connect_e " John Whitmore
2018-07-27 23:28 ` [PATCH 08/10] staging:rtl8192u: Refactor enum dm_dig_pd_th_e " John Whitmore
2018-07-27 23:28 ` [PATCH 09/10] staging:rtl8192u: Refactor enum dm_dig_cs_ratio_e " John Whitmore
2018-07-27 23:28 ` [PATCH 10/10] staging:rtl8192u: Refactor enum DM_CCK_Rx_Path_Method " John Whitmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180727232826.28014-6-johnfwhitmore@gmail.com \
    --to=johnfwhitmore@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox