From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 07/10] staging:rtl8192u: Refactor dm_dig_connect_e - Style
Date: Sat, 28 Jul 2018 00:28:23 +0100 [thread overview]
Message-ID: <20180727232826.28014-8-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180727232826.28014-1-johnfwhitmore@gmail.com>
The enumerated type dm_dig_connect_e is only used to group constant
values, as the actual type is never used as the type for the variables
which use the defined constants (cur_connect_state and pre_connect_state).
These two member variables have had there defined types changed to
properly reflect there usage and to permit compiler type checks to be
performed.
In addition the definition of the enumerated type has been moved above
the structure which uses the type. The typedef of the enumerated type
has been removed to clear the checkpatch issue with defining new types
and the enumerated value DIG_CONNECT_MAX has been removed since it is
never used in code.
The resulting changes are all coding style in nature and should not
impact runtime code execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/r8192U_dm.h | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.h b/drivers/staging/rtl8192u/r8192U_dm.h
index 450bcbe3095e..825df06e17a8 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.h
+++ b/drivers/staging/rtl8192u/r8192U_dm.h
@@ -76,6 +76,11 @@ enum dm_dig_sta_e {
DM_STA_DIG_MAX
};
+enum dm_dig_connect_e {
+ DIG_DISCONNECT = 0,
+ DIG_CONNECT = 1,
+};
+
/* 2007/10/04 MH Define upper and lower threshold of DIG enable or disable. */
struct dig {
u8 dig_enable_flag;
@@ -91,8 +96,8 @@ struct dig {
enum dm_dig_sta_e dig_state;
enum dm_dig_sta_e dig_highpwr_state;
- u8 cur_connect_state;
- u8 pre_connect_state;
+ enum dm_dig_connect_e cur_connect_state;
+ enum dm_dig_connect_e pre_connect_state;
u8 curpd_thstate;
u8 prepd_thstate;
@@ -110,12 +115,6 @@ struct dig {
long rssi_val;
};
-typedef enum tag_dig_connect_definition {
- DIG_DISCONNECT = 0,
- DIG_CONNECT = 1,
- DIG_CONNECT_MAX
-} dm_dig_connect_e;
-
typedef enum tag_dig_packetdetection_threshold_definition {
DIG_PD_AT_LOW_POWER = 0,
DIG_PD_AT_NORMAL_POWER = 1,
--
2.18.0
next prev parent reply other threads:[~2018-07-27 23:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 23:28 [PATCH 00/10] staging:rtl8192u: Refactor enums r8192U_dm.h -Style John Whitmore
2018-07-27 23:28 ` [PATCH 01/10] staging:rtl8192u: Remove unused DM_check_fsync_time_interval - Style John Whitmore
2018-07-27 23:28 ` [PATCH 02/10] staging:rtl8192u: Refactor use of enum dm_dig_sta_e " John Whitmore
2018-07-29 8:17 ` Greg KH
2018-07-29 9:50 ` John Whitmore
2018-07-27 23:28 ` [PATCH 03/10] staging:rtl8192u: Refactor enum dm_ratr_sta_e usage " John Whitmore
2018-07-27 23:28 ` [PATCH 04/10] staging:rtl8192u: Remove enum dm_dig_op_e John Whitmore
2018-07-27 23:28 ` [PATCH 05/10] staging:rtl8192u: Refactor enum dm_dig_alg_e - Style John Whitmore
2018-07-27 23:28 ` [PATCH 06/10] staging:rtl8192u: Remove unused enum dm_dig_dbg_e " John Whitmore
2018-07-27 23:28 ` John Whitmore [this message]
2018-07-27 23:28 ` [PATCH 08/10] staging:rtl8192u: Refactor enum dm_dig_pd_th_e " John Whitmore
2018-07-27 23:28 ` [PATCH 09/10] staging:rtl8192u: Refactor enum dm_dig_cs_ratio_e " John Whitmore
2018-07-27 23:28 ` [PATCH 10/10] staging:rtl8192u: Refactor enum DM_CCK_Rx_Path_Method " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727232826.28014-8-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox