From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86623C46462 for ; Sun, 29 Jul 2018 20:12:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D5F520873 for ; Sun, 29 Jul 2018 20:12:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=thunk.org header.i=@thunk.org header.b="ejb6PWzJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D5F520873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729023AbeG2VoX (ORCPT ); Sun, 29 Jul 2018 17:44:23 -0400 Received: from imap.thunk.org ([74.207.234.97]:40114 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726785AbeG2VoX (ORCPT ); Sun, 29 Jul 2018 17:44:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MwqYN2B+gHMYntI1jnGVT7ccOppkUfdOAgqTkYFgnd8=; b=ejb6PWzJISw7V0OO9NsYwwAKf8 NDsdehJT4DjxIxZC0aCLmx8ct6EDoHTAQ2DoD9zw3tSM/awM2hnAnHsm4WcjhvAuzgfRTvktZ8PvY C+WkKR9G8tFvw29j8RnKP3SbBS+opEyBmaZMwlZ+/JqllBFgV9rzWu2NH0E2N6b5aMQE=; Received: from root (helo=callcc.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.89) (envelope-from ) id 1fjs3V-00061Y-VM; Sun, 29 Jul 2018 20:12:42 +0000 Received: by callcc.thunk.org (Postfix, from userid 15806) id 48E1F7A64C1; Sun, 29 Jul 2018 16:12:36 -0400 (EDT) Date: Sun, 29 Jul 2018 16:12:36 -0400 From: "Theodore Y. Ts'o" To: "Gustavo A. R. Silva" Cc: Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ext4: use swap macro in mext_page_double_lock Message-ID: <20180729201236.GF21725@thunk.org> Mail-Followup-To: "Theodore Y. Ts'o" , "Gustavo A. R. Silva" , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180726174323.GA28731@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180726174323.GA28731@embeddedor.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 26, 2018 at 12:43:23PM -0500, Gustavo A. R. Silva wrote: > Make use of the swap macro and remove unnecessary variable *tmp*. > This makes the code easier to read and maintain. > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Thanks, applied. - Ted