From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH v2 03/08] staging:rtl8192u: Rename member variables - Style
Date: Sun, 29 Jul 2018 22:05:17 +0100 [thread overview]
Message-ID: <20180729210534.10617-7-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180729210534.10617-1-johnfwhitmore@gmail.com>
Rename the member variables of union aci_aifsn, which should be named
in lowercase. The only member variable, of this union, which is
actually used is 'acm'.
This are coding style changes which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 10 +++++-----
drivers/staging/rtl8192u/r8192U_dm.c | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
index 5856bf87c5dc..901b85139d3b 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
@@ -14,13 +14,13 @@
// Ref: WMM spec 2.2.2: WME Parameter Element, p.12.
//
union aci_aifsn {
- u8 charData;
+ u8 char_data;
struct {
- u8 AIFSN:4;
- u8 ACM:1;
- u8 ACI:2;
- u8 Reserved:1;
+ u8 aifsn:4;
+ u8 acm:1;
+ u8 aci:2;
+ u8 reserved:1;
} f; // Field
};
diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
index 04c08ca8a0bb..7dc912dd53af 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.c
+++ b/drivers/staging/rtl8192u/r8192U_dm.c
@@ -2338,7 +2338,7 @@ static void dm_check_edca_turbo(
read_nic_byte(dev, AcmHwCtrl, &AcmCtrl);
- if (pAciAifsn->f.ACM) { /* ACM bit is 1. */
+ if (pAciAifsn->f.acm) { /* acm bit is 1. */
AcmCtrl |= AcmHw_BeqEn;
} else { /* ACM bit is 0. */
AcmCtrl &= (~AcmHw_BeqEn);
--
2.18.0
next prev parent reply other threads:[~2018-07-29 21:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 21:05 [PATCH v2 00/15] staging:rtl8192u: Coding style changes John Whitmore
2018-07-29 21:05 ` [PATCH v2 01/08] staging:rtl8192u: Add spaces around operators - Style John Whitmore
2018-07-29 21:05 ` [PATCH v2 01/15] staging:rtl8192u: Remove typedef of struct cmpk_txfb_t " John Whitmore
2018-07-29 21:05 ` [PATCH v2 02/15] staging:rtl8192u: Remove unused CMPK_TX_SET_CONFIG_SIZE " John Whitmore
2018-07-29 21:05 ` [PATCH v2 02/08] staging:rtl8192u: Rename ACI_AIFSN " John Whitmore
2018-07-29 21:15 ` John Whitmore
2018-07-29 21:05 ` [PATCH v2 03/15] staging:rtl8192u: Removed unused CMPK_RX_DBG_MSG_SIZE " John Whitmore
2018-07-29 21:05 ` John Whitmore [this message]
2018-07-29 21:14 ` [PATCH v2 03/08] staging:rtl8192u: Rename member variables " John Whitmore
2018-07-29 21:05 ` [PATCH v2 04/15] staging:rtl8192u: Correct spelling in comments - style John Whitmore
2018-07-29 21:20 ` [PATCH v2 00/15] staging:rtl8192u: Coding style changes John Whitmore
-- strict thread matches above, loose matches on Subject: below --
2018-07-28 23:14 [PATCH v2 00/08] staging:rtl8192u: cleanup of rtl819x_Qos.h - Style John Whitmore
2018-07-28 23:14 ` [PATCH v2 03/08] staging:rtl8192u: Rename member variables " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180729210534.10617-7-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox