From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH v2 13/15] staging:rtl8192u: Refactor enum dm_dig_pd_th_e - Style
Date: Sun, 29 Jul 2018 22:07:45 +0100 [thread overview]
Message-ID: <20180729210747.10803-14-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180729210747.10803-1-johnfwhitmore@gmail.com>
The enumerated type dm_dig_pd_th_e is never actually used as
the type for the two variables which use the constants, which the
enumeration defines. This omission removes the possibility of taking
advantage of compiler type checking.
To correct this the two member variables, (curpd_thstate & prepd_thstate)
have been changed to use the type enum dig_pkt_detection_threshold rather
then u8.
Additionally the enum's declaration has been moved above the dig
structure, where the type is used, the 'typedef' has been removed to
clear the checkpatch issue with defining new types, and the value
'DIG_PD_MAX' has been removed from the enumeration, since it is never
used in code.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/r8192U_dm.h | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.h b/drivers/staging/rtl8192u/r8192U_dm.h
index 8de6d15fb659..f9d75ad9eaee 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.h
+++ b/drivers/staging/rtl8192u/r8192U_dm.h
@@ -81,6 +81,12 @@ enum dig_connect {
DIG_CONNECT = 1,
};
+enum dig_pkt_detection_threshold {
+ DIG_PD_AT_LOW_POWER = 0,
+ DIG_PD_AT_NORMAL_POWER = 1,
+ DIG_PD_AT_HIGH_POWER = 2,
+};
+
/* 2007/10/04 MH Define upper and lower threshold of DIG enable or disable. */
struct dig {
u8 dig_enable_flag;
@@ -99,8 +105,8 @@ struct dig {
enum dig_connect cur_connect_state;
enum dig_connect pre_connect_state;
- u8 curpd_thstate;
- u8 prepd_thstate;
+ enum dig_pkt_detection_threshold curpd_thstate;
+ enum dig_pkt_detection_threshold prepd_thstate;
u8 curcs_ratio_state;
u8 precs_ratio_state;
@@ -115,13 +121,6 @@ struct dig {
long rssi_val;
};
-typedef enum tag_dig_packetdetection_threshold_definition {
- DIG_PD_AT_LOW_POWER = 0,
- DIG_PD_AT_NORMAL_POWER = 1,
- DIG_PD_AT_HIGH_POWER = 2,
- DIG_PD_MAX
-} dm_dig_pd_th_e;
-
typedef enum tag_dig_cck_cs_ratio_state_definition {
DIG_CS_RATIO_LOWER = 0,
DIG_CS_RATIO_HIGHER = 1,
--
2.18.0
next prev parent reply other threads:[~2018-07-29 21:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 21:07 [PATCH v2 00/15] staging:rtl8192u: Coding style changes John Whitmore
2018-07-29 21:07 ` [PATCH v2 01/15] staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style John Whitmore
2018-07-30 9:11 ` Greg KH
2018-07-30 18:43 ` John Whitmore
2018-07-29 21:07 ` [PATCH v2 02/15] staging:rtl8192u: Remove unused CMPK_TX_SET_CONFIG_SIZE " John Whitmore
2018-07-29 21:07 ` [PATCH v2 03/15] staging:rtl8192u: Removed unused CMPK_RX_DBG_MSG_SIZE " John Whitmore
2018-07-29 21:07 ` [PATCH v2 04/15] staging:rtl8192u: Correct spelling in comments - style John Whitmore
2018-07-29 21:07 ` [PATCH v2 05/15] staging:rtl8192u: Remove typedef of cmpk_intr_sta_t - Style John Whitmore
2018-07-29 21:07 ` [PATCH v2 06/15] staging:rtl8192u: Remove typedef of cmpk_set_cfg_t " John Whitmore
2018-07-29 21:07 ` [PATCH v2 07/15] staging:rtl8192u: Refactor use of enum dm_dig_sta_e " John Whitmore
2018-07-29 21:07 ` [PATCH v2 08/15] staging:rtl8192u: Refactor enum dm_ratr_sta_e usage " John Whitmore
2018-07-29 21:07 ` [PATCH v2 09/15] staging:rtl8192u: Remove enum dm_dig_op_e " John Whitmore
2018-07-29 21:07 ` [PATCH v2 10/15] staging:rtl8192u: Refactor enum dm_dig_alg_e " John Whitmore
2018-07-29 21:07 ` [PATCH v2 11/15] staging:rtl8192u: Remove unused enum dm_dig_dbg_e " John Whitmore
2018-07-29 21:07 ` [PATCH v2 12/15] staging:rtl8192u: Refactor dm_dig_connect_e " John Whitmore
2018-07-29 21:07 ` John Whitmore [this message]
2018-07-29 21:07 ` [PATCH v2 14/15] staging:rtl8192u: Refactor enum dm_dig_cs_ratio_e " John Whitmore
2018-07-29 21:07 ` [PATCH v2 15/15] staging:rtl8192u: Refactor enum DM_CCK_Rx_Path_Method " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180729210747.10803-14-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox