From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9936CFD21E1 for ; Mon, 30 Jul 2018 09:02:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5878520893 for ; Mon, 30 Jul 2018 09:02:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5878520893 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726797AbeG3KgU (ORCPT ); Mon, 30 Jul 2018 06:36:20 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45378 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726505AbeG3KgT (ORCPT ); Mon, 30 Jul 2018 06:36:19 -0400 Received: from localhost (D57D388D.static.ziggozakelijk.nl [213.125.56.141]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 5D4A9CA1; Mon, 30 Jul 2018 09:02:19 +0000 (UTC) Date: Mon, 30 Jul 2018 11:02:16 +0200 From: Greg KH To: Michael Straube Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err() Message-ID: <20180730090216.GA19163@kroah.com> References: <20180729185447.19903-1-straube.linux@gmail.com> <20180729185447.19903-3-straube.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180729185447.19903-3-straube.linux@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote: > The function rtw_handle_tkip_mic_err() is never used, so remove it. > Discovered by cppcheck. That's a bad tool then, as this is used, and the build breaks when this patch is applied :( I've dropped it now. thanks, greg k-h