Re: [PATCH 25/38] Make anon_inodes unconditional [ver #10]

Randy Dunlap
2018-07-27T20:04:20Z

On 07/27/2018 10:34 AM, David Howells wrote:
> Make the anon_inodes facility unconditional so that it can be used by core
> VFS code.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
>
> fs/Makefile | 2 +-
> init/Kconfig | 10 ----------
> 2 files changed, 1 insertion(+), 11 deletions(-)

Hi David,

Please also drop "select ANON_INODES" from other places that select it:

./drivers/vfio/Kconfig:25: select ANON_INODES
./drivers/infiniband/Kconfig:28: select ANON_INODES
./drivers/base/Kconfig:177: select ANON_INODES
./drivers/iio/Kconfig:7: select ANON_INODES
./drivers/dma-buf/Kconfig:6: select ANON_INODES
./drivers/gpio/Kconfig:15: select ANON_INODES
./drivers/char/tpm/Kconfig:160: select ANON_INODES
./arch/arm64/kvm/Kconfig:26: select ANON_INODES
./arch/mips/kvm/Kconfig:23: select ANON_INODES
./arch/powerpc/kvm/Kconfig:23: select ANON_INODES
./arch/arm/kvm/Kconfig:25: select ANON_INODES
./arch/s390/kvm/Kconfig:24: select ANON_INODES
./arch/x86/kvm/Kconfig:30: select ANON_INODES
./arch/x86/Kconfig:49: select ANON_INODES
./fs/notify/inotify/Kconfig:3: select ANON_INODES
./fs/notify/fanotify/Kconfig:4: select ANON_INODES

> diff --git a/fs/Makefile b/fs/Makefile
> index 9a0b8003f069..ae681523b4b1 100644
> --- a/fs/Makefile
> +++ b/fs/Makefile
> @@ -25,7 +25,7 @@ obj-$(CONFIG_PROC_FS) += proc_namespace.o
>
> obj-y += notify/
> obj-$(CONFIG_EPOLL) += eventpoll.o
> -obj-$(CONFIG_ANON_INODES) += anon_inodes.o
> +obj-y += anon_inodes.o
> obj-$(CONFIG_SIGNALFD) += signalfd.o
> obj-$(CONFIG_TIMERFD) += timerfd.o
> obj-$(CONFIG_EVENTFD) += eventfd.o
> diff --git a/init/Kconfig b/init/Kconfig
> index 5a52f07259a2..d8303f4af5d2 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1066,9 +1066,6 @@ config LD_DEAD_CODE_DATA_ELIMINATION
> config SYSCTL
> bool
>
> -config ANON_INODES
> - bool
> -
> config HAVE_UID16
> bool
>
> @@ -1273,14 +1270,12 @@ config HAVE_FUTEX_CMPXCHG
> config EPOLL
> bool "Enable eventpoll support" if EXPERT
> default y
> - select ANON_INODES
> help
> Disabling this option will cause the kernel to be built without
> support for epoll family of system calls.
>
> config SIGNALFD
> bool "Enable signalfd() system call" if EXPERT
> - select ANON_INODES
> default y
> help
> Enable the signalfd() system call that allows to receive signals
> @@ -1290,7 +1285,6 @@ config SIGNALFD
>
> config TIMERFD
> bool "Enable timerfd() system call" if EXPERT
> - select ANON_INODES
> default y
> help
> Enable the timerfd() system call that allows to receive timer
> @@ -1300,7 +1294,6 @@ config TIMERFD
>
> config EVENTFD
> bool "Enable eventfd() system call" if EXPERT
> - select ANON_INODES
> default y
> help
> Enable the eventfd() system call that allows to receive both
> @@ -1414,7 +1407,6 @@ config KALLSYMS_BASE_RELATIVE
> # syscall, maps, verifier
> config BPF_SYSCALL
> bool "Enable bpf() system call"
> - select ANON_INODES
> select BPF
> select IRQ_WORK
> default n
> @@ -1431,7 +1423,6 @@ config BPF_JIT_ALWAYS_ON
>
> config USERFAULTFD
> bool "Enable userfaultfd() system call"
> - select ANON_INODES
> depends on MMU
> help
> Enable the userfaultfd() system call that allows to intercept and
> @@ -1498,7 +1489,6 @@ config PERF_EVENTS
> bool "Kernel performance events and counters"
> default y if PROFILING
> depends on HAVE_PERF_EVENTS
> - select ANON_INODES
> select IRQ_WORK
> select SRCU
> help
>

--
~Randy