Re: [PATCH 36/38] vfs: Add a sample program for the new mount API [ver #10]

Pavel Machek
2018-07-30T20:47:42Z

[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]

Hi!

> But once the string has been generated, it can now be thousands of
> different strings, and you can't just look them up from a table any
> more.
>
> Real examples from David's patch-series:
>
> errorf(fc, "%s: Lookup failure for '%s'",
> desc->name, param->key);
>
> errorf(fc, "%s: Non-blockdev passed to '%s'",
> desc->name, param->key);
>
> which means that by the time user space sees it, you can't just "look
> up the string". The string will have various random key names etc in
> it.
>
> But the alternative to pass things as format strings and raw data, and
> having all the rules for a "good gettext interface" are worse. It gets
> very ugly very quickly.

Dunno. Could we pass it as "format string and data formatted as
_strings_"? That should be possible to deal with in userspace and not
too annoying for the kernel.

Userspace would then get something like
"e%s: Lookup failure for '%s'\0<desc->name>\0<param->key>\0" .

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]