Re: [PATCH 36/38] vfs: Add a sample program for the new mount API [ver #10]

Pavel Machek
2018-07-30T14:31:09Z

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

On Mon 2018-07-30 13:23:31, David Howells wrote:
> Pavel Machek <pavel@ucw.cz> wrote:
>
> > Hmm, so kernel now returns messages in english? Not sure that is
> > reasonable, as that is going to cause problems with translations...
>
> The problem is that if there's no explicit logging route attached, the
> messages get dumped via printk() instead, so they really need to be printable
> strings.

Well, I guess errors should have numbers, and catalog explaining what
error means what. That way userspace can translate, and it is what we
do with errno.

I believe numbers are best. If you hate numbers, you can still use
strings, as long as you can enumerate them in docs (but it will be
strange design).

But anything else is not suitable, I'm afraid.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]