Re: [PATCH 34/38] vfs: syscall: Add fsinfo() to query filesystem information [ver #10]

David Howells
2018-07-27T22:12:30Z

Andy Lutomirski <luto@amacapital.net> wrote:

> > Add a system call to allow filesystem information to be queried. A request
> > value can be given to indicate the desired attribute. Support is provided
> > for enumerating multi-value attributes.
>
> Has anyone seriously reviewed this?

I don't know. I've certainly posted it before.

> > params->request indicates the attribute/attributes to be queried. This can
> > be one of:
> >
> > fsinfo_attr_statfs - statfs-style info
> > fsinfo_attr_fsinfo - Information about fsinfo()
>
> Constants are almost always all caps. Is there any reason these are
> lowercase?

It looks better IMO, particularly for enum constants. I'm not sure if there
are any rules about this in system vs user definitions.

David