From: Christian Brauner <christian@brauner.io>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, arve@android.com,
tkjos@android.com, maco@android.com, rlove@google.com,
ben@decadent.org.uk
Subject: Re: [RFC PATCH 0/4] file: export functions for binder module
Date: Mon, 30 Jul 2018 22:28:40 +0200 [thread overview]
Message-ID: <20180730202840.GA14693@mailbox.org> (raw)
In-Reply-To: <20180730201947.GB12962@bombadil.infradead.org>
On Mon, Jul 30, 2018 at 01:19:47PM -0700, Matthew Wilcox wrote:
> On Mon, Jul 30, 2018 at 10:12:24PM +0200, Christian Brauner wrote:
> > > I don't expect this patch to be mergeable but rather to kick-off a
> > > discussion if we can either simply export them as they are or how we can
> > > get supportable exports that allow access to struct files_struct.
> >
> > Maybe that wasn't obvious from the first message. Is there any way we
> > can come up with a way to have versions of these functions that you
> > would be fine with exporting?
> > The point is that otherwise we would have to either duplicate the code
> > or come up with something way more complex. If you have any pointer that
> > would already help.
>
> He said in the first reply this should probably be using an anonfd.
> If you do that, I think all four of these exports go away.
I try and see if that is possible.
>
> And there was really no reason to post each of the four exports as
> separate patches. That just makes review harder on everyone.
Sorry about that. It usually depends on the preferences of each
maintainer how fine-grained such minor changes should be.
Christian
next prev parent reply other threads:[~2018-07-30 20:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 14:37 [RFC PATCH 0/4] file: export functions for binder module Christian Brauner
2018-07-30 14:37 ` [PATCH 1/4] file: export __alloc_fd() Christian Brauner
2018-07-30 16:31 ` Christoph Hellwig
2018-07-30 20:36 ` Matthew Wilcox
2018-07-30 21:43 ` Al Viro
2018-07-31 8:44 ` Martijn Coenen
2018-07-31 10:07 ` Christian Brauner
2018-07-31 10:37 ` Martijn Coenen
2018-07-30 14:37 ` [PATCH 2/4] file: export __fd_install() Christian Brauner
2018-07-30 16:32 ` Christoph Hellwig
2018-07-30 14:37 ` [PATCH 3/4] file: export get_files_struct() Christian Brauner
2018-07-30 16:32 ` Christoph Hellwig
2018-07-30 14:37 ` [PATCH 4/4] file: export put_files_struct() Christian Brauner
2018-07-30 16:33 ` Christoph Hellwig
2018-07-30 16:34 ` [RFC PATCH 0/4] file: export functions for binder module Christoph Hellwig
2018-07-30 20:12 ` Christian Brauner
2018-07-30 20:19 ` Matthew Wilcox
2018-07-30 20:28 ` Christian Brauner [this message]
2018-07-30 21:41 ` Al Viro
2018-08-02 13:31 ` Christian Brauner
2018-07-31 14:27 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730202840.GA14693@mailbox.org \
--to=christian@brauner.io \
--cc=arve@android.com \
--cc=ben@decadent.org.uk \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=rlove@google.com \
--cc=tkjos@android.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).