public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [RFC] perf annotate: option to report global percentage
Date: Tue, 31 Jul 2018 11:21:28 +0200	[thread overview]
Message-ID: <20180731092128.GA17617@krava> (raw)
In-Reply-To: <20180719082539.GB18667@krava>

On Thu, Jul 19, 2018 at 10:25:39AM +0200, Jiri Olsa wrote:
> On Wed, Jul 18, 2018 at 02:55:14PM -0700, Stephane Eranian wrote:
> > Hi Jiri,
> > 
> > As far as I know, once you go into annotate mode, via perf report TUI
> > mode, the percentage you see per instruction is relative to the
> > function. I would like the option to display the total percentage,
> > i..e, the importance of the instruction for the entire run. Right now,
> > if I want that, I need to do function_percentage * insn_percentage by
> > hand. This is not convenient. Having a key toggle would be very
> > useful, worst case a cmdline option.
> > 
> > What do you think?
> 
> hi,
> that should be simple to add, we already have the 'F' in the
> main browser window to toggle among full/filtered scale
> 
> I'll try to add something similar for annotation window

sry for delay, I was out last week

I put something together and pushed it in here:
  git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
  perf/annotate_percent

there's the 'p' key to switch between local and global period
I haven't added any command line option for stdio yet

I'll have more testing and post later but any feedback
now would be great

thanks,
jirka

  reply	other threads:[~2018-07-31  9:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18 21:55 [RFC] perf annotate: option to report global percentage Stephane Eranian
2018-07-19  8:25 ` Jiri Olsa
2018-07-31  9:21   ` Jiri Olsa [this message]
2018-08-03  7:28     ` Stephane Eranian
2018-08-03 11:29       ` Jiri Olsa
2018-08-03 15:51         ` Arnaldo Carvalho de Melo
2018-08-03 20:12           ` Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180731092128.GA17617@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox