The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Jeremy Cline <jcline@redhat.com>
Cc: Jan Kara <jack@suse.com>,
	linux-kernel@vger.kernel.org, Andreas Dilger <adilger@dilger.ca>
Subject: Re: [PATCH 0/2] fs/quota: Fix potential spectre v1 gadgets
Date: Tue, 31 Jul 2018 13:43:44 -0500	[thread overview]
Message-ID: <20180731184344.yspy7sjbec74d5w6@treble> (raw)
In-Reply-To: <20180731013731.1987-1-jcline@redhat.com>

On Tue, Jul 31, 2018 at 01:37:29AM +0000, Jeremy Cline wrote:
> Hi folks,
> 
> This series unifies XQM_MAXQUOTAS with MAXQUOTAS, which were both being
> used to perform bounds checks on arrays, and then sanitizes 'type' so it
> can't be used in speculative out-of-bounds array access.
> 
> Jeremy Cline (2):
>   fs/quota: Replace XQM_MAXQUOTAS usage with MAXQUOTAS
>   fs/quota: Fix spectre gadget in do_quotactl
> 
>  fs/quota/quota.c               | 14 +++++++-------
>  include/linux/quota.h          |  8 +-------
>  include/uapi/linux/dqblk_xfs.h |  5 -----
>  3 files changed, 8 insertions(+), 19 deletions(-)

Looks good to me, though this might hinge on the discussion with
Andreas:

  https://lkml.kernel.org/r/E3E7B6AF-3819-4998-9B12-DACB4EBC14F1@dilger.ca

-- 
Josh

  parent reply	other threads:[~2018-07-31 18:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31  1:37 [PATCH 0/2] fs/quota: Fix potential spectre v1 gadgets Jeremy Cline
2018-07-31  1:37 ` [PATCH 1/2] fs/quota: Replace XQM_MAXQUOTAS usage with MAXQUOTAS Jeremy Cline
2018-08-22 16:05   ` Jan Kara
2018-08-22 16:17     ` Jan Kara
2018-07-31  1:37 ` [PATCH 2/2] fs/quota: Fix spectre gadget in do_quotactl Jeremy Cline
2018-08-22 16:08   ` Jan Kara
2018-07-31 18:43 ` Josh Poimboeuf [this message]
2018-08-22 16:12   ` [PATCH 0/2] fs/quota: Fix potential spectre v1 gadgets Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180731184344.yspy7sjbec74d5w6@treble \
    --to=jpoimboe@redhat.com \
    --cc=adilger@dilger.ca \
    --cc=jack@suse.com \
    --cc=jcline@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox