From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1718C43142 for ; Tue, 31 Jul 2018 18:44:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FDF420841 for ; Tue, 31 Jul 2018 18:44:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FDF420841 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731997AbeGaUZu (ORCPT ); Tue, 31 Jul 2018 16:25:50 -0400 Received: from mail.bootlin.com ([62.4.15.54]:47812 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729772AbeGaUZu (ORCPT ); Tue, 31 Jul 2018 16:25:50 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 92944207AA; Tue, 31 Jul 2018 20:44:11 +0200 (CEST) Received: from localhost (unknown [88.191.26.124]) by mail.bootlin.com (Postfix) with ESMTPSA id 693A9206A8; Tue, 31 Jul 2018 20:44:01 +0200 (CEST) Date: Tue, 31 Jul 2018 20:44:02 +0200 From: Alexandre Belloni To: Andy Shevchenko Cc: Wolfram Sang , Jarkko Nikula , James Hogan , Paul Burton , Mika Westerberg , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Thomas Petazzoni , Allan Nielsen Subject: Re: [PATCH v2 1/6] i2c: designware: use generic table matching Message-ID: <20180731184402.GY28585@piout.net> References: <20180731134740.441-1-alexandre.belloni@bootlin.com> <20180731134740.441-2-alexandre.belloni@bootlin.com> <44e52856371e4b5c102df8f2efebd527fd26b066.camel@linux.intel.com> <0559c93256ae4f59aed278912bcbfd996e279839.camel@linux.intel.com> <20180731143059.GV28585@piout.net> <1cbe4c184a0a6db1fc5401dbd8bd3a9f6bf22527.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1cbe4c184a0a6db1fc5401dbd8bd3a9f6bf22527.camel@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/07/2018 17:53:17+0300, Andy Shevchenko wrote: > On Tue, 2018-07-31 at 16:30 +0200, Alexandre Belloni wrote: > > On 31/07/2018 17:23:04+0300, Andy Shevchenko wrote: > > > On Tue, 2018-07-31 at 17:02 +0300, Andy Shevchenko wrote: > > > > On Tue, 2018-07-31 at 15:47 +0200, Alexandre Belloni wrote: > > > > > > + dev->flags |= (u32)device_get_match_data(&pdev->dev); > > > > > + > > > > > > And since it would be changed anyway, can you actually move this > > > line > > > closet to if (has_acpi_companion()) one ? > > > > > > > I need that value to be set before calling of_configure though. > > AFAICS, you added those lines later, so, it would be something like > > dev->flags |= ... > > if (of_node) > of_configure() > if (has_acpi_companion()) > acpi_configure() > > Would it work for you? > Works for me, I'll send v3 soon. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com