From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 01/14] staging:rtl8192u: Clean cmpk_counttxstatistic() comments - Style
Date: Tue, 31 Jul 2018 21:59:52 +0100 [thread overview]
Message-ID: <20180731210005.17452-2-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180731210005.17452-1-johnfwhitmore@gmail.com>
The only useful piece of information in the header comment of this
static function was the name of the function and parameters. That
is not useful information, given that they are in the C Source of
the function declaration, a few lines below the comment. The block
comment has been removed.
This is a coding style change, there should be no impact on runtime
code execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/staging/rtl8192u/r819xU_cmdpkt.c
index d2293a335ed1..900f7866d381 100644
--- a/drivers/staging/rtl8192u/r819xU_cmdpkt.c
+++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.c
@@ -60,24 +60,6 @@ rt_status SendTxCommandPacket(struct net_device *dev, void *pData, u32 DataLen)
return RT_STATUS_SUCCESS;
}
-/*-----------------------------------------------------------------------------
- * Function: cmpk_counttxstatistic()
- *
- * Overview:
- *
- * Input: PADAPTER pAdapter
- * STRUCT CMD_PKT_TX_FEEDBACK *psTx_FB
- *
- * Output: NONE
- *
- * Return: NONE
- *
- * Revised History:
- * When Who Remark
- * 05/12/2008 amy Create Version 0 porting from windows code.
- *
- *---------------------------------------------------------------------------
- */
static void cmpk_count_txstatistic(struct net_device *dev, struct cmd_pkt_tx_feedback *pstx_fb)
{
struct r8192_priv *priv = ieee80211_priv(dev);
--
2.18.0
next prev parent reply other threads:[~2018-07-31 21:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 20:59 [PATCH 00/14] staging:rtl8192u: rtl819x_Qos.h style changes John Whitmore
2018-07-31 20:59 ` John Whitmore [this message]
2018-07-31 20:59 ` [PATCH 02/14] staging:rtl8192u: Remove union from aci_aifsn - Style John Whitmore
2018-07-31 20:59 ` [PATCH 03/14] staging:rtl8192u: Remove union from qos_tsinfo " John Whitmore
2018-07-31 20:59 ` [PATCH 04/14] staging:rtl8192u: Rename members of struct " John Whitmore
2018-07-31 20:59 ` [PATCH 05/14] staging:rtl8192u: Refactor union TSPEC_BODY " John Whitmore
2018-07-31 20:59 ` [PATCH 06/14] staging:rtl8192u: Rename TSInfo " John Whitmore
2018-07-31 20:59 ` [PATCH 07/14] staging:rtl8192u: Rename tspec_body members " John Whitmore
2018-07-31 20:59 ` [PATCH 08/14] staging:rtl8192u: Remove commented out code " John Whitmore
2018-07-31 21:00 ` [PATCH 09/14] staging:rtl8192u: Move QOS_TCLAS to rtl819x_TS.h " John Whitmore
2018-07-31 21:00 ` [PATCH 10/14] staging:rtl8192u: rename OCTET_STRING " John Whitmore
2018-07-31 21:00 ` [PATCH 11/14] staging:rtl8192u: Rename octet_string members " John Whitmore
2018-07-31 21:00 ` [PATCH 12/14] staging:rtl8192u: Remove unused UP2AC " John Whitmore
2018-07-31 21:00 ` [PATCH 13/14] staging:rtl8192u: Rename IsACValid and add parenthesis " John Whitmore
2018-07-31 21:00 ` [PATCH 14/14] staging:rtl8192u: Change clock comment " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731210005.17452-2-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox