From: Byungchul Park <byungchul.park@lge.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, kernel-team@lge.com,
ying.huang@intel.com, mingo@kernel.org, jiangshanlai@gmail.com,
paulmck@linux.vnet.ibm.com, josh@joshtriplett.org,
mathieu.desnoyers@efficios.com, joel@joelfernandes.org,
len.brown@intel.com, glider@google.com, peter@hurleysoftware.com,
aik@ozlabs.ru
Subject: Re: [QUESTION] llist: Comment releasing 'must delete' restriction before traversing
Date: Wed, 1 Aug 2018 14:35:21 +0900 [thread overview]
Message-ID: <20180801053521.GB25338@X58A-UD3R> (raw)
In-Reply-To: <20180731094616.6d70c130@gandalf.local.home>
On Tue, Jul 31, 2018 at 09:46:16AM -0400, Steven Rostedt wrote:
> On Tue, 31 Jul 2018 18:38:09 +0900
> Byungchul Park <byungchul.park@lge.com> wrote:
>
> > On Tue, Jul 31, 2018 at 10:52:57AM +0200, Peter Zijlstra wrote:
> > > On Tue, Jul 31, 2018 at 09:58:36AM +0900, Byungchul Park wrote:
> > > > In restrictive cases like only addtions happen but never deletion, can't
> > > > we safely traverse a llist? I believe llist can be more useful if we can
> > > > release the restriction. Can't we?
> > >
> > > Yes you can, but I'm not sure it makes much sense to confuse the
> > > comments with this.
> > >
> > > This really ends up in the 'you had better know what you're doing'
> > > category.
> >
> > Partially agree with you. But why not add more explanation?
> >
> > If you think the comment confuse us, then it's ok to keep it itself.
> >
>
> It appears that you will only have your own users that will be doing
> this, correct? How many use cases have no deletion? I wouldn't change
> the generic comments on llist for something that's a one off and hardly
> used.
Thanks for the comment. OK.
> -- Steve
prev parent reply other threads:[~2018-08-01 5:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 0:58 [QUESTION] llist: Comment releasing 'must delete' restriction before traversing Byungchul Park
2018-07-31 1:37 ` Huang, Ying
2018-07-31 5:25 ` Byungchul Park
2018-07-31 5:45 ` Huang, Ying
2018-07-31 4:30 ` Paul E. McKenney
2018-07-31 9:29 ` Byungchul Park
2018-07-31 14:30 ` Paul E. McKenney
2018-08-01 5:34 ` Byungchul Park
2018-08-01 5:43 ` Huang, Ying
2018-08-01 8:52 ` Byungchul Park
2018-07-31 8:52 ` Peter Zijlstra
2018-07-31 9:38 ` Byungchul Park
2018-07-31 13:46 ` Steven Rostedt
2018-08-01 5:35 ` Byungchul Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801053521.GB25338@X58A-UD3R \
--to=byungchul.park@lge.com \
--cc=aik@ozlabs.ru \
--cc=glider@google.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=kernel-team@lge.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peter@hurleysoftware.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox