From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9D6FC28CF6 for ; Wed, 1 Aug 2018 08:22:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D1752083E for ; Wed, 1 Aug 2018 08:22:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="YjSvKIkm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D1752083E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388023AbeHAKHV (ORCPT ); Wed, 1 Aug 2018 06:07:21 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:50764 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387633AbeHAKHV (ORCPT ); Wed, 1 Aug 2018 06:07:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0aFC+ZzYQIpCZrjB90LN8FiAICGN3HzxTxaymKzg6Fw=; b=YjSvKIkmb55/uAuexQPzViq8H LkNKm5kSZ5q7+AKBAAYhZ7naGi3gsdUpydPBBJams8F5N1jh4YJg0oRrGx+oCvjj+DweEXxcqIjqV Z3PV/ExbnLozG9OfuBjPukWFfilXdUojVuXy+WB9dXNfUEzTUYOJsslNeFqiUR7wabsNw/dBpfnb6 I3tx6KwPYc3USGfbNP0KnCzgW67WL+fLLJSC6yYOg9OU4LxKCDsn/fs5pi6JEWCXKactevTztDlDF 64CTBaBVr1PV9rB3pLZulM6NoYFGAXThFs07KzM7HXGw96MBpwuZYvp8PeaNpZqCJg5xBxD7MDPRP oy6BF7zGw==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fkmOi-0000fq-Nu; Wed, 01 Aug 2018 08:22:20 +0000 Date: Wed, 1 Aug 2018 01:22:20 -0700 From: Christoph Hellwig To: Kees Cook Cc: Jens Axboe , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Sagar Dharia , Randy Dunlap , Vinod Koul , David Kershner , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/9] block: Switch struct packet_command to use struct scsi_sense_hdr Message-ID: <20180801082220.GA26378@infradead.org> References: <20180731195155.46664-1-keescook@chromium.org> <20180731195155.46664-6-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180731195155.46664-6-keescook@chromium.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 31, 2018 at 12:51:50PM -0700, Kees Cook wrote: > There is a lot of needless struct request_sense usage in the CDROM > code. These can all be struct scsi_sense_hdr instead, to avoid any > confusion over their respective structure sizes. This patch is a lot > of noise changing "sense" to "sshdr", but the final code is more > readable to distinguish between "sense" meaning "struct request_sense" > and "sshdr" meaning "struct scsi_sense_hdr". Looks good, Reviewed-by: Christoph Hellwig