From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Commit "new primitive: discard_new_inode()" introduces a problem
Date: Wed, 1 Aug 2018 17:11:51 +0100 [thread overview]
Message-ID: <20180801161151.GO30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <96e3c195-aaca-9214-0dcd-5c2b970a72ae@virtuozzo.com>
On Wed, Aug 01, 2018 at 06:43:56PM +0300, Kirill Tkhai wrote:
> #git status
> HEAD detached at 22dc9a168272
Wait a sec - just that commit? With discard_new_inode() not even
used anywhere? Then any of those -ENOMEM is disguised ERR_PTR(-ESTALE)
from find_inode()/find_inode_fast(), i.e. an inode found by
iget5_locked() (your /etc is on ext4) with I_CREATING still set.
And that is set only by insert_inode_locked()/insert_inode_locked4(),
and only until unlock_new_inode().
Could you slap WARN_ON(1) before these return ERR_PTR(-ESTALE) in
find_inode{,_fast}() and see if that's what's getting triggered?
next prev parent reply other threads:[~2018-08-01 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 14:43 Commit "new primitive: discard_new_inode()" introduces a problem Kirill Tkhai
2018-08-01 15:19 ` Al Viro
2018-08-01 15:43 ` Kirill Tkhai
2018-08-01 16:11 ` Al Viro [this message]
2018-08-01 16:16 ` Al Viro
2018-08-01 16:19 ` Kirill Tkhai
2018-08-01 16:34 ` Al Viro
2018-08-02 3:14 ` Rafael David Tinoco
2018-08-02 7:43 ` Kirill Tkhai
2018-08-01 16:27 ` Al Viro
2018-08-02 2:36 ` Rafael David Tinoco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801161151.GO30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=ktkhai@virtuozzo.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox