From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Salyzyn <salyzyn@android.com>
Cc: linux-kernel@vger.kernel.org,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Kees Cook <keescook@chromium.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
security@kernel.org, kernel-team@android.com,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH] HID: Bluetooth: hidp: buffer overflow in hidp_process_report
Date: Wed, 1 Aug 2018 18:37:03 +0200 [thread overview]
Message-ID: <20180801163703.GA6994@kroah.com> (raw)
In-Reply-To: <20180731220225.159741-1-salyzyn@android.com>
On Tue, Jul 31, 2018 at 03:02:13PM -0700, Mark Salyzyn wrote:
> CVE-2018-9363
>
> The buffer length is unsigned at all layers, but gets cast to int and
> checked in hidp_process_report and can lead to a buffer overflow.
> Switch len parameter to unsigned int to resolve issue.
>
> This affects 3.18 and newer kernels.
>
> Signed-off-by: Mark Salyzyn <salyzyn@android.com>
> Fixes: a4b1b5877b514b276f0f31efe02388a9c2836728 ("HID: Bluetooth: hidp: make sure input buffers are big enough")
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: Johan Hedberg <johan.hedberg@gmail.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: linux-bluetooth@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: security@kernel.org
> Cc: kernel-team@android.com
Nit, you only need to bother security@ if you do not have a fix and need
to figure out one.
Also, you forgot to cc: stable@vger.kernel.org to be included in older
kernel releases :(
thanks,
greg k-h
next prev parent reply other threads:[~2018-08-01 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 22:02 [PATCH] HID: Bluetooth: hidp: buffer overflow in hidp_process_report Mark Salyzyn
2018-07-31 23:41 ` Kees Cook
2018-08-01 7:16 ` Marcel Holtmann
2018-08-01 16:37 ` Greg KH [this message]
2018-08-01 16:41 ` Mark Salyzyn
2018-08-01 17:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801163703.GA6994@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benjamin.tissoires@redhat.com \
--cc=davem@davemloft.net \
--cc=jkosina@suse.cz \
--cc=johan.hedberg@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=salyzyn@android.com \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox