From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C28BAC28CF6 for ; Wed, 1 Aug 2018 17:43:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87307208A5 for ; Wed, 1 Aug 2018 17:43:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87307208A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405311AbeHATaL (ORCPT ); Wed, 1 Aug 2018 15:30:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56030 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389882AbeHATaK (ORCPT ); Wed, 1 Aug 2018 15:30:10 -0400 Received: from localhost (D57E6652.static.ziggozakelijk.nl [213.126.102.82]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id D047DCBA; Wed, 1 Aug 2018 17:43:21 +0000 (UTC) Date: Wed, 1 Aug 2018 19:09:26 +0200 From: Greg KH To: Mark Salyzyn Cc: linux-kernel@vger.kernel.org, Marcel Holtmann , Johan Hedberg , "David S. Miller" , Kees Cook , Benjamin Tissoires , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, stable , kernel-team@android.com, Jiri Kosina Subject: Re: [PATCH] HID: Bluetooth: hidp: buffer overflow in hidp_process_report Message-ID: <20180801170926.GA7829@kroah.com> References: <20180731220225.159741-1-salyzyn@android.com> <20180801163703.GA6994@kroah.com> <6f6c3e63-0847-b0b6-98a3-7ad62fd2697c@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6f6c3e63-0847-b0b6-98a3-7ad62fd2697c@android.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 01, 2018 at 09:41:04AM -0700, Mark Salyzyn wrote: > On 08/01/2018 09:37 AM, Greg KH wrote: > > On Tue, Jul 31, 2018 at 03:02:13PM -0700, Mark Salyzyn wrote: > > > CVE-2018-9363 > > > > > > The buffer length is unsigned at all layers, but gets cast to int and > > > checked in hidp_process_report and can lead to a buffer overflow. > > > Switch len parameter to unsigned int to resolve issue. > > > > > > This affects 3.18 and newer kernels. > > > > > > Signed-off-by: Mark Salyzyn > > > Fixes: a4b1b5877b514b276f0f31efe02388a9c2836728 ("HID: Bluetooth: hidp: make sure input buffers are big enough") > > > Cc: Marcel Holtmann > > > Cc: Johan Hedberg > > > Cc: "David S. Miller" > > > Cc: Kees Cook > > > Cc: Benjamin Tissoires > > > Cc: linux-bluetooth@vger.kernel.org > > > Cc: netdev@vger.kernel.org > > > Cc: linux-kernel@vger.kernel.org > > > Cc: security@kernel.org > > > Cc: kernel-team@android.com > > Nit, you only need to bother security@ if you do not have a fix and need > > to figure out one. > > Thanks, I thought anything with a CVE was to go there according to netdev > FAQ (dropped security from response list). > > Also, you forgot to cc: stable@vger.kernel.org to be included in older > > kernel releases :( > netdev FAQ said to _not_ copy stable, I am so confused ;-{ (added stable to > response list b/c patch is now taken into bluetooth-next) Ah, well, bluetooth is a bit not normal here, usually stuff that ends up in a subsystem tree before netdev needs to have a cc: stable on it for me to catch it. Hopefully the bluetooth maintainers are on it :) thanks, greg k-h